-
Notifications
You must be signed in to change notification settings - Fork 210
Refactor deployment list page #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1 @@ | |||
| export type LoadingStatus = "idle" | "loading" | "succeeded" | "failed"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, sorry for the dumb question but I don't understand when do we need "idle" state 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khanhtc1202
idle is used to represent the state before fetching.
https://redux.js.org/tutorials/essentials/part-5-async-logic#loading-state-for-requests
It is not used currently, but it will be used in other modules/components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, got it, thank you 🙏
|
/lgtm |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1178
Does this PR introduce a user-facing change?: