Skip to content

Conversation

@cakecatz
Copy link
Contributor

What this PR does / why we need it:

  • This refactoring will fix a bug that not refreshed deployment list

Which issue(s) this PR fixes:

Fixes #1178

Does this PR introduce a user-facing change?:

NONE

@@ -0,0 +1 @@
export type LoadingStatus = "idle" | "loading" | "succeeded" | "failed";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, sorry for the dumb question but I don't understand when do we need "idle" state 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanhtc1202
idle is used to represent the state before fetching.

https://redux.js.org/tutorials/essentials/part-5-async-logic#loading-state-for-requests

It is not used currently, but it will be used in other modules/components.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, got it, thank you 🙏

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.27%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.13%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 3b0a9c5 into master Dec 17, 2020
@pipecd-bot pipecd-bot deleted the refactor-deployment-list-page branch December 17, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refresh page on switch between Application and Deployment tabs

5 participants