Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Dec 15, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Dec 15, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.68%. This pull request increases coverage by 0.14%.

File Function Base Head Diff
pkg/model/deployment.go DeploymentStatusesFromStrings -- 0.00% +0.00%
pkg/model/deployment.go DeploymentStatusStrings -- 0.00% +0.00%
pkg/app/piped/logpersister/stagelogpersister.go stageLogPersister.flushFromLastCheckpoint 50.00% 61.11% +11.11%
pkg/app/pipectl/cmd/application/add.go newAddCommand 0.00% -- +-0.00%
pkg/app/pipectl/cmd/application/add.go add.run 0.00% -- +-0.00%
pkg/app/pipectl/cmd/application/application.go NewCommand 0.00% -- +-0.00%
pkg/app/pipectl/cmd/application/sync.go newSyncCommand 0.00% -- +-0.00%
pkg/app/pipectl/cmd/application/sync.go sync.run 0.00% -- +-0.00%
pkg/app/pipectl/cmd/application/sync.go makeStatuses 100.00% -- -100.00%
pkg/app/pipectl/cmd/application/sync.go availableStatuses 100.00% -- -100.00%
pkg/app/pipectl/cmd/deployment/deployment.go NewCommand 0.00% -- +-0.00%
pkg/app/pipectl/cmd/deployment/waitstatus.go newWaitStatusCommand 0.00% -- +-0.00%
pkg/app/pipectl/cmd/deployment/waitstatus.go waitStatus.run 0.00% -- +-0.00%
pkg/app/pipectl/cmd/deployment/waitstatus.go makeStatuses 100.00% -- -100.00%
pkg/app/pipectl/cmd/deployment/waitstatus.go availableStatuses 100.00% -- -100.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 81.41%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 236359f into master Dec 15, 2020
@pipecd-bot pipecd-bot deleted the owners branch December 15, 2020 02:11
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants