Add a package for yaml templating #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakabonne
commented
Dec 11, 2020
pkg/yamlutil/yamlutil_test.go
Outdated
Comment on lines
175
to
184
| name: "there is an useless blank line", | ||
| yml: ` | ||
| foo: | ||
| - bar | ||
| - baz`, | ||
| path: "$.foo[0]", | ||
| value: "new-text", | ||
| want: []byte(`foo: | ||
| - new-text | ||
| - baz`), |
Member
Author
There was a problem hiding this comment.
Another consideration is this package removes useless empty lines if there is. What do you think about it?
Collaborator
|
Code coverage for golang is
|
Member
|
/lgtm |
Member
Author
|
Thank you :-) |
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Dec 14, 2020
Member
Author
|
Thanks. Fixed them. |
Member
|
/approve |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new package which includes functions:
It will depend on the goccy/go-yaml package which lets us handle the yaml AST.
And Let me know another cool name other than
yamlutilif there is.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: