Add implementation for pipectl tool #1241

nghialv · 2020-12-11T09:11:01Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

Introducing the CLI tool: pipectl

nghialv · 2020-12-11T09:11:18Z

/cc @khanhtc1202

pipecd-bot · 2020-12-11T09:11:58Z

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/pipectl/cmd/deployment/waitstatus_test.go

--- pkg/app/pipectl/cmd/deployment/waitstatus_test.go.orig
+++ pkg/app/pipectl/cmd/deployment/waitstatus_test.go
@@ -42,8 +42,8 @@
 			name:     "ok",
 			statuses: []string{"SUCCESS", "PLANNED"},
 			expected: map[model.DeploymentStatus]struct{}{
-				model.DeploymentStatus_DEPLOYMENT_SUCCESS: struct{}{},
-				model.DeploymentStatus_DEPLOYMENT_PLANNED: struct{}{},
+				model.DeploymentStatus_DEPLOYMENT_SUCCESS: {},
+				model.DeploymentStatus_DEPLOYMENT_PLANNED: {},
 			},
 		},
 	}

pipecd-bot

Some issues were detected while linting go source files in your changes.

pkg/app/pipectl/log/log.go

pipecd-bot · 2020-12-11T09:16:43Z

Code coverage for golang is 33.31%. This pull request decreases coverage by -0.17%.

File	Function	Base	Head	Diff
pkg/app/pipectl/cmd/deployment/deployment.go	NewCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	newWaitStatusCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	waitStatus.run	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	makeDeploymentStatuses	`--`	`100.00%`	`+100.00%`
pkg/cli/cmd.go	runWithContext	`78.26%`	`77.27%`	`-0.99%`

pkg/app/pipectl/cmd/application/sync.go

pkg/app/pipectl/cmd/application/add.go

pkg/app/pipectl/cmd/deployment/waitstatus.go

nghialv · 2020-12-14T03:39:49Z

I just realized that we need a wait-status after syncing an application for our B team.
So changed this PR to be WIP.

pipecd-bot · 2020-12-14T06:05:58Z

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/pipectl/client/deployment.go

--- pkg/app/pipectl/client/deployment.go.orig
+++ pkg/app/pipectl/client/deployment.go
@@ -20,9 +20,10 @@
 	"strings"
 	"time"
 
+	"go.uber.org/zap"
+
 	"github.com/pipe-cd/pipe/pkg/app/api/service/apiservice"
 	"github.com/pipe-cd/pipe/pkg/model"
-	"go.uber.org/zap"
 )
 
 // WaitDeploymentStatuses waits a given deployment until it reaches one of the specified statuses.

nghialv · 2020-12-14T06:09:30Z

pkg/log/log.go

 			StacktraceKey:  "stacktrace",
 			LineEnding:     zapcore.DefaultLineEnding,
 			EncodeLevel:    encodeLevel,
-			EncodeTime:     HumanizeTimeEncoder,


Removed TimeEncoder from humanize mode to simplify the log output of CLI.

pipecd-bot · 2020-12-14T06:17:13Z

Code coverage for golang is 33.31%. This pull request decreases coverage by -0.17%.

File	Function	Base	Head	Diff
pkg/app/pipectl/cmd/application/add.go	newAddCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/add.go	add.run	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/application.go	NewCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/sync.go	newSyncCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/sync.go	sync.run	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/sync.go	makeStatuses	`--`	`100.00%`	`+100.00%`
pkg/app/pipectl/cmd/application/sync.go	availableStatuses	`--`	`100.00%`	`+100.00%`
pkg/app/pipectl/cmd/deployment/deployment.go	NewCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	newWaitStatusCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	waitStatus.run	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	makeStatuses	`--`	`100.00%`	`+100.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	availableStatuses	`--`	`100.00%`	`+100.00%`
pkg/cli/cmd.go	runWithContext	`78.26%`	`77.27%`	`-0.99%`
pkg/log/log.go	HumanizeTimeEncoder	`100.00%`	`--`	`-100.00%`

pkg/app/pipectl/cmd/application/sync.go

nakabonne · 2020-12-14T07:11:29Z

pkg/app/pipectl/cmd/application/add.go

+func newAddCommand(root *command) *cobra.Command {
+	c := &add{
+		root:                  root,
+		gitPathConfigFileName: ".pipe.yaml",


I feel like it should be changeable via --config-file-name or something like that. And the default value should refer to pkg.model.DefaultDeploymentConfigFileName.

Sorry, I just now found it has been already changeable.

👍 I changed to use the value defined in the model package and simplified the flags.

pipecd-bot · 2020-12-14T07:23:44Z

Code coverage for golang is 33.31%. This pull request decreases coverage by -0.17%.

File	Function	Base	Head	Diff
pkg/app/pipectl/cmd/application/add.go	newAddCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/add.go	add.run	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/application.go	NewCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/sync.go	newSyncCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/sync.go	sync.run	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/application/sync.go	makeStatuses	`--`	`100.00%`	`+100.00%`
pkg/app/pipectl/cmd/application/sync.go	availableStatuses	`--`	`100.00%`	`+100.00%`
pkg/app/pipectl/cmd/deployment/deployment.go	NewCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	newWaitStatusCommand	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	waitStatus.run	`--`	`0.00%`	`+0.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	makeStatuses	`--`	`100.00%`	`+100.00%`
pkg/app/pipectl/cmd/deployment/waitstatus.go	availableStatuses	`--`	`100.00%`	`+100.00%`
pkg/cli/cmd.go	runWithContext	`78.26%`	`77.27%`	`-0.99%`
pkg/log/log.go	HumanizeTimeEncoder	`100.00%`	`--`	`-100.00%`

nakabonne · 2020-12-14T07:25:16Z

/lgtm

khanhtc1202 · 2020-12-14T07:35:06Z

/approve

pipecd-bot · 2020-12-14T07:35:09Z

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Add implementation for pipectl tool

5d6d1fd

pipecd-bot added the size/XL label Dec 11, 2020

pipecd-bot requested review from cakecatz and nakabonne December 11, 2020 09:11

pipecd-bot requested a review from khanhtc1202 December 11, 2020 09:11

pipecd-bot reviewed Dec 11, 2020

View reviewed changes

pkg/app/pipectl/log/log.go Outdated Show resolved Hide resolved

nakabonne reviewed Dec 13, 2020

View reviewed changes

pkg/app/pipectl/cmd/application/sync.go Outdated Show resolved Hide resolved

pkg/app/pipectl/cmd/application/add.go Outdated Show resolved Hide resolved

pkg/app/pipectl/cmd/application/add.go Outdated Show resolved Hide resolved

nakabonne reviewed Dec 14, 2020

View reviewed changes

pkg/app/pipectl/cmd/deployment/waitstatus.go Outdated Show resolved Hide resolved

nghialv changed the title ~~Add implementation for pipectl tool~~ [WIP] Add implementation for pipectl tool Dec 14, 2020

pipecd-bot added the do-not-merge/wip label Dec 14, 2020

nghialv added 2 commits December 14, 2020 14:02

Switch to use the default logger

c9e8cd5

Add wait-status option to sync-app command

149ee87

pipecd-bot added the area/pipectl label Dec 14, 2020

Fix lint

d22518e

nghialv commented Dec 14, 2020

View reviewed changes

Fix wait-status flag

c41064a

nghialv changed the title ~~[WIP] Add implementation for pipectl tool~~ Add implementation for pipectl tool Dec 14, 2020

pipecd-bot removed the do-not-merge/wip label Dec 14, 2020

khanhtc1202 reviewed Dec 14, 2020

View reviewed changes

pkg/app/pipectl/cmd/application/sync.go Show resolved Hide resolved

nakabonne reviewed Dec 14, 2020

View reviewed changes

Simplify git-path flags

f633ca0

pipecd-bot added the lgtm label Dec 14, 2020

pipecd-bot added the approved label Dec 14, 2020

pipecd-bot merged commit 750c8ee into master Dec 14, 2020

pipecd-bot deleted the pipectl branch December 14, 2020 07:41

pipecd-bot mentioned this pull request Dec 16, 2020

Add doc for pipectl #1266

Merged

Add implementation for pipectl tool #1241

Add implementation for pipectl tool #1241

Uh oh!

Conversation

nghialv commented Dec 11, 2020

Uh oh!

nghialv commented Dec 11, 2020

Uh oh!

pipecd-bot commented Dec 11, 2020

Uh oh!

pipecd-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pipecd-bot commented Dec 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nghialv commented Dec 14, 2020

Uh oh!

pipecd-bot commented Dec 14, 2020

Uh oh!

nghialv Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

pipecd-bot commented Dec 14, 2020

Uh oh!

Uh oh!

nakabonne Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

nakabonne Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

nghialv Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

pipecd-bot commented Dec 14, 2020

Uh oh!

nakabonne commented Dec 14, 2020

Uh oh!

khanhtc1202 commented Dec 14, 2020

Uh oh!

pipecd-bot commented Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants