Skip to content

Conversation

@mura-s
Copy link
Contributor

@mura-s mura-s commented Dec 9, 2020

What this PR does / why we need it:

This PR does:

  • Add ability to automatically recreate piped pods when executing helm upgrade to update a piped configuration.

Which issue(s) this PR fixes:

Fixes #1216

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

CLA

Welcome @mura-s!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@mura-s
Copy link
Contributor Author

mura-s commented Dec 9, 2020

/cla sign

@pipecd-bot
Copy link
Collaborator

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

@nghialv
Copy link
Member

nghialv commented Dec 9, 2020

Thank you!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.96%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit e685dec into master Dec 9, 2020
@pipecd-bot pipecd-bot deleted the auto-recreate-piped-pods branch December 9, 2020 07:02
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically recreate piped pods when executing helm upgrade to update a piped configuration

4 participants