Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Add test-mod target on Makefile in case run test for specific modules/dirs.
Test with DIR=pkg/app/api make test-mod command.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.66%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Dec 8, 2020

Not sure why do we need this?
Just running make test and Bazel automatically detects what should be tested.

@khanhtc1202
Copy link
Member Author

khanhtc1202 commented Dec 8, 2020

Not sure why do we need this?
Just running make test and Bazel automatically detects what should be tested.

not sure what when wrong but on my local, make test usually run all the tests on a newly opened terminal session 🤔 So I thought at least specific which dirs/modules of tests should be run bring better development experience.

@nghialv
Copy link
Member

nghialv commented Dec 8, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 8d931d9 into master Dec 8, 2020
@pipecd-bot pipecd-bot deleted the test-module-target branch December 8, 2020 12:45
@khanhtc1202
Copy link
Member Author

@nghialv I somehow figured out what happened on my local, rebuild/rerun test occurred on switching between editor's terminal ( Vscode ) and os's terminal 👀
did it occur on your end 👀 ( update .bazelrc may resolve this issue )
ref: bazelbuild/intellij#789

@nghialv
Copy link
Member

nghialv commented Dec 8, 2020

@khanhtc1202 lol. It worked perfectly for me. I am using the same zsh for both terminal and VScode.

@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants