Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Dec 3, 2020

What this PR does / why we need it:

  • Implement some features(generate a key, list keys)
    • Disabling key is not implemented yet(I will create a PR to implement this after merged)

Ref: #1146

screenshots

image

image

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Add API Key management page for generating/displaying API keys to use for external services

* Implement generate key, list keys
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.28%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.18%. This pull request increases coverage by 0.04%.

File Base Head Diff
src/constants/path.ts 100.00% 100.00% +0.00%
src/modules/api-keys.ts 83.87% 84.85% +0.98%
src/modules/index.ts 100.00% 100.00% +0.00%

@cakecatz cakecatz self-assigned this Dec 3, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.28%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.18%. This pull request increases coverage by 0.04%.

File Base Head Diff
src/constants/path.ts 100.00% 100.00% +0.00%
src/modules/api-keys.ts 83.87% 84.85% +0.98%
src/modules/index.ts 100.00% 100.00% +0.00%

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d2ef064 into master Dec 3, 2020
@pipecd-bot pipecd-bot deleted the api-keys-page branch December 3, 2020 07:55
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants