Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 30, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Unify the SSO config for both GitHub and GitHub Enterprise. GITHUB_ENTERPRISE provider name was deprecated.

@nghialv nghialv changed the title Unify the SSO config for both GitHub and GitHub Enterprise [WIP] Unify the SSO config for both GitHub and GitHub Enterprise Nov 30, 2020
@nghialv nghialv requested a review from gkuga November 30, 2020 02:57
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.21%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/oauth/github/github.go NewOAuthClient 0.00% 0.00% +0.00%
pkg/app/api/authhandler/callback.go getUser 0.00% 0.00% +0.00%
pkg/model/project.go ProjectSSOConfig.GenerateAuthCodeURL 0.00% 0.00% +0.00%
pkg/oauth/github/github.go newGHEOAuthClient 0.00% -- +-0.00%

@nghialv nghialv force-pushed the github-sso-refactoring branch from 639ecea to 94b89c4 Compare November 30, 2020 05:10
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.28%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/app/api/authhandler/callback.go getUser 0.00% 0.00% +0.00%
pkg/model/project.go ProjectSSOConfig.GenerateAuthCodeURL 0.00% 0.00% +0.00%
pkg/oauth/github/github.go NewOAuthClient 0.00% 0.00% +0.00%
pkg/oauth/github/github.go newGHEOAuthClient 0.00% -- +-0.00%

@nghialv nghialv force-pushed the github-sso-refactoring branch from 94b89c4 to f2c3535 Compare December 1, 2020 02:34
@nghialv nghialv changed the title [WIP] Unify the SSO config for both GitHub and GitHub Enterprise Unify the SSO config for both GitHub and GitHub Enterprise Dec 1, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.28%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/app/api/authhandler/callback.go getUser 0.00% 0.00% +0.00%
pkg/model/project.go ProjectSSOConfig.GenerateAuthCodeURL 0.00% 0.00% +0.00%
pkg/oauth/github/github.go NewOAuthClient 0.00% 0.00% +0.00%
pkg/oauth/github/github.go newGHEOAuthClient 0.00% -- +-0.00%

@gkuga
Copy link
Contributor

gkuga commented Dec 1, 2020

/approve

1 similar comment
@nghialv
Copy link
Member Author

nghialv commented Dec 1, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d134f07 into master Dec 1, 2020
@pipecd-bot pipecd-bot deleted the github-sso-refactoring branch December 1, 2020 03:04
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants