Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 27, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.20%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/api/grpcapi/web_api.go WebAPI.GenerateAPIKey -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.DisableAPIKey -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.ListAPIKeys -- 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d0fc0ad into master Nov 27, 2020
@pipecd-bot pipecd-bot deleted the apikey branch November 27, 2020 08:16
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants