Skip to content

Rename package pkg/app/api/api to grpcapi #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Nov 27, 2020
Merged

Rename package pkg/app/api/api to grpcapi #1150

pipecd-bot merged 1 commit into from
Nov 27, 2020
+13 −13

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 26, 2020

What this PR does / why we need it:

Because we are planning to add the HTTP API into the server service,
this PR renames the existing api package at pkg/app/api to grpcapi to get more clear.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Nov 26, 2020

/cc @nakabonne

@pipecd-bot pipecd-bot requested a review from nakabonne November 26, 2020 14:00
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 26, 2020

COVERAGE

Code coverage for golang is 32.96%. This pull request increases coverage by 0.00%.

File Function Base Head Diff
pkg/app/api/grpcapi/fake_web_api.go NewFakeWebAPI -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.Register -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.AddEnvironment -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.UpdateEnvironmentDesc -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.ListEnvironments -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.RegisterPiped -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.RecreatePipedKey -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.EnablePiped -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.DisablePiped -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.ListPipeds -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetPiped -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.AddApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.EnableApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.DisableApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.ListApplications -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.SyncApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GenerateApplicationSealedSecret -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.ListDeployments -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetStageLog -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.CancelDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.ApproveStage -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetApplicationLiveState -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetProject -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.UpdateProjectStaticAdmin -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.EnableStaticAdmin -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.DisableStaticAdmin -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.UpdateProjectSSOConfig -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.UpdateProjectRBACConfig -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetMe -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.GetCommand -- 0.00% +0.00%
pkg/app/api/grpcapi/fake_web_api.go FakeWebAPI.ListDeploymentConfigTemplates -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go NewPipedAPI -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.Register -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.Ping -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportPipedMeta -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.GetEnvironment -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ListApplications -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationSyncState -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationMostRecentDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.GetApplicationMostRecentDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ListNotCompletedDeployments -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportDeploymentPlanned -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportDeploymentStatusChanged -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportDeploymentCompleted -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.SaveDeploymentMetadata -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.SaveStageMetadata -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportStageLogs -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportStageLogsFromLastCheckpoint -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportStageStatusChanged -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ListUnhandledCommands -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportCommandHandled -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.getCommand -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationLiveState -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationLiveStateEvents -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.validateAppBelongsToPiped -- 80.00% +80.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.validateDeploymentBelongsToPiped -- 80.00% +80.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.validateEnvBelongsToProject -- 80.00% +80.00%
pkg/app/api/grpcapi/web_api.go NewWebAPI -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.Register -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.AddEnvironment -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.UpdateEnvironmentDesc -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.ListEnvironments -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.RegisterPiped -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.RecreatePipedKey -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.EnablePiped -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.DisablePiped -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.updatePiped -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.ListPipeds -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetPiped -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.getPiped -- 57.14% +57.14%
pkg/app/api/grpcapi/web_api.go WebAPI.validatePipedBelongsToProject -- 91.67% +91.67%
pkg/app/api/grpcapi/web_api.go WebAPI.AddApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.makeGitPath -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.EnableApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.DisableApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.updateApplicationEnable -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.ListApplications -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.SyncApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.addCommand -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetApplication -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GenerateApplicationSealedSecret -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.getApplication -- 57.14% +57.14%
pkg/app/api/grpcapi/web_api.go WebAPI.validateAppBelongsToProject -- 91.67% +91.67%
pkg/app/api/grpcapi/web_api.go WebAPI.ListDeployments -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.getDeployment -- 57.14% +57.14%
pkg/app/api/grpcapi/web_api.go WebAPI.validateDeploymentBelongsToProject -- 91.67% +91.67%
pkg/app/api/grpcapi/web_api.go WebAPI.GetStageLog -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.CancelDeployment -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.ApproveStage -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetApplicationLiveState -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetProject -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.getProject -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.UpdateProjectStaticAdmin -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.EnableStaticAdmin -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.DisableStaticAdmin -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.UpdateProjectSSOConfig -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.UpdateProjectRBACConfig -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetMe -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.GetCommand -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go WebAPI.ListDeploymentConfigTemplates -- 0.00% +0.00%
pkg/app/api/grpcapi/web_api.go filterDeploymentConfigTemplates -- 100.00% +100.00%
pkg/app/api/api/fake_web_api.go NewFakeWebAPI 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.Register 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.AddEnvironment 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateEnvironmentDesc 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.ListEnvironments 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.RegisterPiped 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.RecreatePipedKey 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.EnablePiped 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.DisablePiped 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.ListPipeds 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetPiped 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.AddApplication 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.EnableApplication 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.DisableApplication 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.ListApplications 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.SyncApplication 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetApplication 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GenerateApplicationSealedSecret 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.ListDeployments 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetDeployment 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetStageLog 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.CancelDeployment 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.ApproveStage 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetApplicationLiveState 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetProject 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectStaticAdmin 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.EnableStaticAdmin 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.DisableStaticAdmin 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectSSOConfig 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectRBACConfig 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetMe 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.GetCommand 0.00% -- +-0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.ListDeploymentConfigTemplates 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go NewPipedAPI 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.Register 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.Ping 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportPipedMeta 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.GetEnvironment 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ListApplications 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportApplicationSyncState 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportApplicationMostRecentDeployment 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.GetApplicationMostRecentDeployment 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ListNotCompletedDeployments 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.CreateDeployment 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportDeploymentPlanned 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportDeploymentStatusChanged 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportDeploymentCompleted 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.SaveDeploymentMetadata 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.SaveStageMetadata 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportStageLogs 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportStageLogsFromLastCheckpoint 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportStageStatusChanged 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ListUnhandledCommands 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportCommandHandled 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.getCommand 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportApplicationLiveState 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.ReportApplicationLiveStateEvents 0.00% -- +-0.00%
pkg/app/api/api/piped_api.go PipedAPI.validateAppBelongsToPiped 80.00% -- -80.00%
pkg/app/api/api/piped_api.go PipedAPI.validateDeploymentBelongsToPiped 80.00% -- -80.00%
pkg/app/api/api/piped_api.go PipedAPI.validateEnvBelongsToProject 80.00% -- -80.00%
pkg/app/api/api/web_api.go NewWebAPI 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.Register 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.AddEnvironment 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateEnvironmentDesc 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.ListEnvironments 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.RegisterPiped 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.RecreatePipedKey 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.EnablePiped 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.DisablePiped 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.updatePiped 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.ListPipeds 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GetPiped 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.getPiped 57.14% -- -57.14%
pkg/app/api/api/web_api.go WebAPI.validatePipedBelongsToProject 91.67% -- -91.67%
pkg/app/api/api/web_api.go WebAPI.AddApplication 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.makeGitPath 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.EnableApplication 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.DisableApplication 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.updateApplicationEnable 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.ListApplications 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.SyncApplication 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.addCommand 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GetApplication 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GenerateApplicationSealedSecret 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.getApplication 57.14% -- -57.14%
pkg/app/api/api/web_api.go WebAPI.validateAppBelongsToProject 91.67% -- -91.67%
pkg/app/api/api/web_api.go WebAPI.ListDeployments 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GetDeployment 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.getDeployment 57.14% -- -57.14%
pkg/app/api/api/web_api.go WebAPI.validateDeploymentBelongsToProject 91.67% -- -91.67%
pkg/app/api/api/web_api.go WebAPI.GetStageLog 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.CancelDeployment 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.ApproveStage 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GetApplicationLiveState 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GetProject 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.getProject 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectStaticAdmin 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.EnableStaticAdmin 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.DisableStaticAdmin 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectSSOConfig 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectRBACConfig 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GetMe 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.GetCommand 0.00% -- +-0.00%
pkg/app/api/api/web_api.go WebAPI.ListDeploymentConfigTemplates 0.00% -- +-0.00%
pkg/app/api/api/web_api.go filterDeploymentConfigTemplates 100.00% -- -100.00%

nakabonne
nakabonne approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 27, 2020

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 63805e1 into master Nov 27, 2020
@pipecd-bot pipecd-bot deleted the api branch November 27, 2020 00:56
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakecatz cakecatz Awaiting requested review from cakecatz

@stormcat24 stormcat24 Awaiting requested review from stormcat24

1 more reviewer

@nakabonne nakabonne nakabonne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/api area/server release-note-none size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nghialv @pipecd-bot @nakabonne