Skip to content

Conversation

@cakecatz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Nov 19, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.94%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.17%. This pull request increases coverage by 1.25%.

File Base Head Diff
src/components/project-setting-labeled-text.tsx -- 100.00% +100.00%
src/components/static-admin-form.tsx -- 93.02% +93.02%
src/constants/text.ts -- 100.00% +100.00%
src/constants/toast-text.ts -- 100.00% +100.00%
src/mocks/services/project.ts -- 100.00% +100.00%
src/styles/project-setting.ts -- 100.00% +100.00%
src/api/project.ts 25.00% 41.67% +16.67%
src/mocks/handlers.ts 100.00% 100.00% +0.00%
src/modules/project.ts 58.33% 69.44% +11.11%

@pipecd-bot pipecd-bot merged commit e734a1f into master Nov 19, 2020
@pipecd-bot pipecd-bot deleted the refactor-static-admin-form branch November 19, 2020 07:51
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants