Extend createAsyncAction API to be able to carry over request information to success and failure handlers

[abersnaze]

I have a bunch of epics that have a similar pattern.

export const fooAction = createAsyncAction(
    'FOO_INIT',
    'FOO_DONE',
    'FOO_ERROR')<Foo, Bar, Error>();

The problem that I'm having is that the Error type loses the request value (of type Foo). To properly mutated the state in the reducer I've had to compose the Error and Foo together in the epic. So the async action creator now looks like this.

export const fooAction = createAsyncAction(
    'FOO_INIT',
    'FOO_DONE',
    'FOO_ERROR')<Foo, [Foo, Bar], [Foo, Error]>();

I was wondering if the request payload can be carried over to the success and failure actions?

InputAction would be the same { type: string, payload: I }
OutputAction would be { type: string, payload: O, request: I }
ErrorAction would be { type: string, payload: E, request: I }

[piotrwitek]

Hi @abersnaze,
I think it should work, could you please provide full usage snippets including reducer so I can have more insight.

[Carl-Foster]

This seems like a specific use case, seems strange to add this to this library.

[piotrwitek]

@Carl-Foster I think the intention here is to add a more generic API to createAsyncAction with an ability to extend action with custom properties. We can already do it with createStandardAction().map API, so it would stay consistent.

export const add = createStandardAction(ADD).map(
  ({ title }: { title: string }) => ({
    payload: { title, id: cuid(), completed: false } as Todo,
	request: 'whatever you want',
  })
);

To be honest I was thinking about adding something similar initially on createAsyncAction, but it was too big effort at that time so I dropped it.

I'll come back to this issue again at some point when I solve some other pending issues that are more important ATM.

[IssueHuntBot]

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

[IssueHuntBot]

@IssueHunt has funded $60.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[piotrwitek]

Here the solution to the requested feature with the new v5.0.0 API using meta arguments:

export const fooAction = createAsyncAction(
    'FOO_INIT',
    'FOO_DONE',
    'FOO_ERROR'
)<Foo, [Bar, Foo], [Error, Foo]>();

fooAction.request(foo);
fooAction.success(bar, foo);
fooAction.failure(err, foo);

Results:
InputAction would be the same { type: string, payload: I }
OutputAction would be { type: string, payload: O, meta: I }
ErrorAction would be { type: string, payload: E, meta: I }