Skip to content

tslib dependencies vs devDependecies in 1.x releases #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnhrdt opened this issue May 9, 2018 · 5 comments
Closed

tslib dependencies vs devDependecies in 1.x releases #32

lnhrdt opened this issue May 9, 2018 · 5 comments
Assignees

Comments

@lnhrdt
Copy link

lnhrdt commented May 9, 2018

tslib is declared under devDependencies but it makes test fail and should instead be declared under dependencies.

I see you've fixed it for the upcoming 2.0 (thanks!) but the issue is also present in the 1.x releases (verified in 1.1.2). Can you release a fix for the 1.x releases as well?

@piotrwitek
Copy link
Owner

@lnhrdt sure thing, I'll do it in a next hour

@piotrwitek piotrwitek self-assigned this May 9, 2018
@piotrwitek
Copy link
Owner

@lnhrdt
Copy link
Author

lnhrdt commented May 9, 2018

Thanks for the fast help @piotrwitek! I really appreciate it, and this tool looks really promising.

I'm still having problems a working application with 1.1.3 because I can't figure out how to create a RootAction type. It seems getReturnOfExpression was removed from typesafe-actions and $call the function doesn't exist (same problem as in piotrwitek/react-redux-typescript-guide#73).

I know you're cooking up some really cool stuff for v2.x but until that's ready do you have an up-to-date example using 1.1.3? The API seems to have changed so much through the 1.x versions that docs aren't helping me and I haven't been able to figure it out on my own.

@piotrwitek
Copy link
Owner

#25 (comment)

If you still want to stick to 1.1.3 the only thing I can advise is to get $call from here: https://github.com/piotrwitek/utility-types/tree/v1.1.0

@lnhrdt
Copy link
Author

lnhrdt commented May 9, 2018

@piotrwitek awesome, thanks for the tip!
But I also just saw your update in #25 about releasing 2.x tomorrow. I'll just wait until then! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants