Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AsyncActionCreator type signature to handle optional cancel property correctly #153

Closed
piotrwitek opened this issue May 15, 2019 · 3 comments
Labels

Comments

@piotrwitek
Copy link
Owner

piotrwitek commented May 15, 2019

Issuehunt badges

Is your feature request related to a real problem or use-case?

Fix cancel is never #152

Describe a solution including usage in code example

Improve the resulting type signature of AsyncActionCreator making it more consistent with the rest of the API surface and to handle optional cancel property correctly.

The resulting signature must be looking like this:

AsyncActionCreator<["FETCH_USERS_REQUEST", undefined], ["FETCH_USERS_SUCCESS", User[]], ["FETCH_USERS_FAILURE", Error], ["FETCH_USERS_CANCEL", string]>

Who does this impact? Who is this for?

All

Describe alternatives you've considered (optional)


IssueHunt Summary

Sponsors (Total: $40.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 18, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Jun 18, 2019

@issuehunt has funded $40.00 to this issue.


@piotrwitek
Copy link
Owner Author

blocking because there is a significant amount of changes in the next branch (currently heavily WIP) that needs to be completed before possible to fix that. There is also a pretty high chance it will be fixed by #143

@piotrwitek
Copy link
Owner Author

Resolved by #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant