feat(un-es6-class): support extending super class

[g-plane]

This PR only handles extending class (class C extends B {}) but doesn't handle super() call. super() call should be solved in separated PR.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wakaru	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 24, 2023 2:26am

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4f9d9fc) 91.33% compared to head (6332c2c) 91.41%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
...kages/unminify/src/transformations/un-es6-class.ts	93.02%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   91.33%   91.41%   +0.07%     
==========================================
  Files          82       82              
  Lines       10460    10539      +79     
  Branches     1424     1450      +26     
==========================================
+ Hits         9554     9634      +80     
+ Misses        866      864       -2     
- Partials       40       41       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pionxzh]

At first, I thought this should be implemented in another way. Finding helper functions like _createClass and _defineProperty is unreliable because minifier will destroy them. Instead, we can do this in the runtime helper transform (code). But these helper functions are too special to be implemented in that way.

This PR can be merged, and we can have another one that adds these helpers into the module scanning, and use the minified name from the module scanning result.

[g-plane]

I see. We can wait for implementing helper functions detecting before merging this PR.

[g-plane]

Helper functions like __extends or _inherits are generated as inline, not imported as modules:

• Babel
• SWC
• TypeScript

How can we detect them?

[0xdevalias]

Helper functions like __extends or _inherits are generated as inline, not imported as modules:

How can we detect them?

@g-plane While I don't know the specific answer to that off the top of my head, here are the relevant issues/references related to it:

• Babel:
  • https://github.com/pionxzh/wakaru/blob/main/packages/unminify/src/transformations/runtime-helpers/index.ts#L11-L20
  • https://github.com/pionxzh/wakaru/tree/main/packages/unminify/src/transformations/runtime-helpers/babel
• swc: Support detect and replace swc's runtime-helpers #50
• TypeScript: Support detect and replace microsoft/tslib's runtime-helpers #55

Also:

• https://github.com/pionxzh/wakaru/tree/main/packages/unminify#wakaruunminify

  • It covered most of patterns that are used by the following tools:

    • Terser (Check the Terser Progress)
    • Babel (Check the Babel Progress)
    • SWC (Check the SWC Progress)
    • TypeScript

  • https://github.com/pionxzh/wakaru/tree/main/packages/unminify/src/transformations/runtime-helpers
• Module detection #41

[pionxzh]

Helper functions like __extends or _inherits are generated as inline, not imported as modules:

• Babel
• SWC
• TypeScript

How can we detect them?

Based on what I know, helpers can be inlined or extracted. Currently, the module scanning is based on regex matching (see babel reference) which also works for inlined helpers.

These examples have been updated to external-helper mode.

• Babel
• SWC

[g-plane]

Babel runtime helpers detection is added.

[pionxzh]

Seems like these helpers can also be imported from the runtime helpers.

import _classCallCheck from "@babel/runtime/helpers/classCallCheck";
import _createClass from "@babel/runtime/helpers/createClass";
import _inherits from "@babel/runtime/helpers/inherits";
import _createSuper from "@babel/runtime/helpers/createSuper";

[pionxzh]

Oh, super will be handled in another PR, so it doesn't matter. OK OK