Make pickle version for python_memcache_serializer adjustable #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
approved these changes
Sep 7, 2018
jparise
reviewed
Sep 7, 2018
pymemcache/serde.py
Outdated
| pickler.dump(value) | ||
| value = output.getvalue() | ||
|
|
||
| return value, flags | ||
|
|
||
|
|
||
| def get_python_memcache_serializer_pickle_version(pickle_version=None): |
There was a problem hiding this comment.
I think this could be shortened to get_python_memcache_serializer(), in case there are other reasonable parameters to provide in the future. That will keep the public API more stable.
There was a problem hiding this comment.
good idea, I am bad at naming things.
pymemcache/serde.py
Outdated
|
|
||
|
|
||
| python_memcache_serializer = partial( | ||
| _python_memcache_serializer, pickle_version=DEFAULT_PICKLE_VERSION) |
There was a problem hiding this comment.
This could just call get_python_memcache_serializer.
jparise
reviewed
Sep 7, 2018
It's unsafe to use the max pickle version when you are switching between versions of python with different max versions. Add a new function get_python_memcache_serializer that returns a python_memcache_serializer with any pickle version.
|
added a few lines to getting_started to cover the serde module |
jparise
reviewed
Sep 12, 2018
nichochar
approved these changes
Sep 12, 2018
jparise
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unsafe to use the max pickle version when you are switching between
versions of python with different max versions.
Add a new function get_python_memcache_serializer_pickle_version that
returns a python_memcache_serializer with any pickle version.