Use make commands on the CI so it actually fails (#286)

* Use make commands

* Fix tests

* Rename 'lint' make command to 'cocoapods'

Author: garrettmoon

.github/workflows/ci.yaml

@@ -11,41 +11,34 @@ on:
       - master
 
 jobs:
-  build:
-    name: Build
+  test:
+    name: Test
     runs-on: macOS-latest
     strategy:
       matrix:
         platform: ['iOS Simulator,name=iPhone 8']
     steps:
       - uses: actions/checkout@v1
-      - name: Analyze and Test
-        run: |
-          xcodebuild clean analyze test \
-            -destination "platform=${{ matrix.platform }}" \
-            -sdk "iphonesimulator" \
-            -project PINCache.xcodeproj \
-            -scheme PINCache \
-            ONLY_ACTIVE_ARCH=NO \
-            CODE_SIGNING_REQUIRED=NO \
-            CLANG_ANALYZER_OUTPUT=plist-html \
-            CLANG_ANALYZER_OUTPUT_DIR="$(pwd)/clang" \
-           | xcpretty
-          if [[ -n `find $(pwd)/clang -name "*.html"` ]] ; then rm -rf $(pwd)/clang; exit 1; fi
-          rm -rf $(pwd)/clang
+      - name: Test
+        run: make test
+  analyze:
+    name: Analyze
+    runs-on: macOS-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: analyze
+        run: make analyze
   cocoapods:
     name: CocoaPods
     runs-on: macOS-latest
     steps:
       - uses: actions/checkout@v1
       - name: Lint
-        run: pod lib lint
+        run: make cocoapods
   carthage:
     name: Carthage
     runs-on: macOS-latest
     steps:
       - uses: actions/checkout@v1
-      - name: Update
-        run: carthage update --no-use-binaries --no-build
-      - name: Build
-        run: carthage build --no-skip-current
+      - name: carthage
+        run: make carthage

Makefile

@@ -2,9 +2,9 @@ PLATFORM="platform=iOS Simulator,name=iPhone 8"
 SDK="iphonesimulator"
 SHELL=/bin/bash -o pipefail
 
-.PHONY: all lint test carthage analyze
+.PHONY: all cocoapods test carthage analyze
 
-lint:
+cocoapods:
 	pod lib lint
 
 analyze:
@@ -25,4 +25,4 @@ carthage:
 	carthage update --no-use-binaries --no-build
 	carthage build --no-skip-current
 
-all: carthage lint test analyze
+all: carthage cocoapods test analyze

Tests/PINCacheTests.m

@@ -735,13 +735,13 @@ - (void)testAgeLimit
     }];
 
     dispatch_group_enter(group);
-    [self.cache.diskCache objectForKeyAsync:key1 completion:^(id<PINCaching> cache, NSString *key, id<NSCoding> object) {
+    [self.cache.diskCache objectForKeyAsync:key1 completion:^(PINDiskCache * _Nonnull cache, NSString * _Nonnull key, id<NSCoding>  _Nullable object) {
         diskObj1 = object;
         dispatch_group_leave(group);
     }];
 
     dispatch_group_enter(group);
-    [self.cache.diskCache objectForKeyAsync:key2 completion:^(id<PINCaching> cache, NSString *key, id<NSCoding> object) {
+    [self.cache.diskCache objectForKeyAsync:key2 completion:^(PINDiskCache * _Nonnull cache, NSString * _Nonnull key, id<NSCoding>  _Nullable object) {
         diskObj2 = object;
         dispatch_group_leave(group);
     }];
@@ -778,13 +778,13 @@ - (void)testAgeLimit
     }];
 
     dispatch_group_enter(group);
-    [self.cache.diskCache objectForKeyAsync:key1 completion:^(id<PINCaching> cache, NSString *key, id<NSCoding> object) {
+    [self.cache.diskCache objectForKeyAsync:key1 completion:^(PINDiskCache * _Nonnull cache, NSString * _Nonnull key, id<NSCoding>  _Nullable object) {
         diskObj1 = object;
         dispatch_group_leave(group);
     }];
 
     dispatch_group_enter(group);
-    [self.cache.diskCache objectForKeyAsync:key2 completion:^(PINDiskCache *cache, NSString *key, id<NSCoding> object) {
+    [self.cache.diskCache objectForKeyAsync:key2 completion:^(PINDiskCache * _Nonnull cache, NSString * _Nonnull key, id<NSCoding>  _Nullable object) {
         diskObj2 = object;
         dispatch_group_leave(group);
     }];
@@ -909,7 +909,7 @@ - (void)_testTTLCacheObjectAccess {
     }];
 
     dispatch_group_enter(group);
-    [self.cache.diskCache objectForKeyAsync:key completion:^(id<PINCaching> cache, NSString *key, id<NSCoding> object) {
+    [self.cache.diskCache objectForKeyAsync:key completion:^(PINDiskCache * _Nonnull cache, NSString * _Nonnull key, id<NSCoding> _Nullable object) {
         diskObj = object;
         dispatch_group_leave(group);
     }];
@@ -933,7 +933,7 @@ - (void)_testTTLCacheObjectAccess {
     }];
 
     dispatch_group_enter(group);
-    [self.cache.diskCache objectForKeyAsync:key completion:^(id<PINCaching> cache, NSString *key, id<NSCoding> object) {
+    [self.cache.diskCache objectForKeyAsync:key completion:^(PINDiskCache * _Nonnull cache, NSString * _Nonnull key, id<NSCoding> _Nullable object) {
         diskObj = object;
         dispatch_group_leave(group);
     }];