Skip to content

Commit c757a04

Browse files
committed
[#NOISSUE] code cleanup
1 parent 5cc4e04 commit c757a04

File tree

3 files changed

+0
-20
lines changed

3 files changed

+0
-20
lines changed

metric-module/metric/src/main/java/com/navercorp/pinpoint/metric/web/dao/SystemMetricDao.java

-3
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,5 @@
2828
*/
2929
public interface SystemMetricDao<T extends Number> {
3030

31-
@Deprecated
32-
List<SystemMetricPoint<T>> getSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag);
33-
3431
Future<List<SystemMetricPoint<T>>> getAsyncSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag);
3532
}

metric-module/metric/src/main/java/com/navercorp/pinpoint/metric/web/dao/pinot/PinotSystemMetricDoubleDao.java

-14
Original file line numberDiff line numberDiff line change
@@ -49,20 +49,6 @@ public PinotSystemMetricDoubleDao(SqlSessionTemplate sqlPinotSessionTemplate, Pi
4949
this.asyncTemplate = Objects.requireNonNull(asyncTemplate, "asyncTemplate");
5050
}
5151

52-
@Override
53-
@Deprecated
54-
public List<SystemMetricPoint<Double>> getSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag) {
55-
StopWatch watch = StopWatch.createStarted();
56-
logger.info("=========== thread start {} thread. tag:{}", Thread.currentThread().getName(), metricTag);
57-
58-
SystemMetricDataSearchKey systemMetricDataSearchKey = new SystemMetricDataSearchKey(metricDataSearchKey, metricTag);
59-
List<SystemMetricPoint<Double>> result = sqlPinotSessionTemplate.selectList(NAMESPACE + "selectSampledSystemMetricData", systemMetricDataSearchKey);
60-
61-
watch.stop();
62-
logger.info("============ thread end {} thread. executeTime:{} tag:{}", Thread.currentThread().getName(), watch.getTime(), metricTag);
63-
return result;
64-
}
65-
6652
@Override
6753
public Future<List<SystemMetricPoint<Double>>> getAsyncSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag) {
6854
SystemMetricDataSearchKey systemMetricDataSearchKey = new SystemMetricDataSearchKey(metricDataSearchKey, metricTag);

metric-module/metric/src/main/java/com/navercorp/pinpoint/metric/web/service/SystemMetricDataServiceImpl.java

-3
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ private List<MetricValue<? extends Number>> getMetricValues(MetricDataSearchKey
9393
Metric elementOfBasicGroupList = systemMetricBasicGroupManager.findElementOfBasicGroup(metricDataSearchKey.getMetricDefinitionId());
9494

9595
StopWatch watch = StopWatch.createStarted();
96-
logger.info("=========== thread start {} thread. metricDefinitionId:{}", Thread.currentThread().getName(), metricDataSearchKey.getMetricDefinitionId());
9796
List<QueryResult<Number>> queryResults = selectAll(metricDataSearchKey, elementOfBasicGroupList, tags);
9897

9998
List<MetricValue<?>> metricValueList = new ArrayList<>(elementOfBasicGroupList.getFields().size());
@@ -111,12 +110,10 @@ private List<MetricValue<? extends Number>> getMetricValues(MetricDataSearchKey
111110
StopWatch dataProcessWatch = StopWatch.createStarted();
112111
MetricValue<Double> doubleMetricValue = createSystemMetricValue(timeWindow, result.getTag(), doubleList, DoubleUncollectedDataCreator.UNCOLLECTED_DATA_CREATOR);
113112
dataProcessWatch.stop();
114-
logger.info("##### execute process data {} thread. processTime:{} metricDefinitionId:{}", Thread.currentThread().getName(), dataProcessWatch.getTime(), metricDataSearchKey.getMetricDefinitionId());
115113
metricValueList.add(doubleMetricValue);
116114
}
117115
}
118116

119-
logger.info("============ thread end {} thread. executeTime:{} metricDefinitionId:{}", Thread.currentThread().getName(), watch.getTime(), metricDataSearchKey.getMetricDefinitionId());
120117
watch.stop();
121118
return metricValueList;
122119
} catch (Throwable e) {

0 commit comments

Comments
 (0)