Skip to content

Commit 5aad118

Browse files
committed
[#9633] Replace List with Map
1 parent dad8e43 commit 5aad118

File tree

3 files changed

+10
-173
lines changed

3 files changed

+10
-173
lines changed

profiler/src/main/java/com/navercorp/pinpoint/profiler/context/scope/DefaultTraceScopePool.java

+10-12
Original file line numberDiff line numberDiff line change
@@ -16,33 +16,31 @@
1616
package com.navercorp.pinpoint.profiler.context.scope;
1717

1818
import com.navercorp.pinpoint.bootstrap.context.scope.TraceScope;
19-
import com.navercorp.pinpoint.profiler.util.NameValueList;
19+
20+
import java.util.HashMap;
21+
import java.util.Map;
22+
import java.util.Objects;
2023

2124
/**
2225
* @author jaehong.kim
2326
*/
2427
public class DefaultTraceScopePool {
2528

26-
private final NameValueList<TraceScope> list = new NameValueList<>();
29+
private final Map<String, TraceScope> map = new HashMap<>();
2730

2831
public TraceScope get(String name) {
29-
if (name == null) {
30-
throw new IllegalArgumentException("name");
31-
}
32+
Objects.requireNonNull(name, "name");
3233

33-
return list.get(name);
34+
return map.get(name);
3435
}
3536

3637
public TraceScope add(String name) {
37-
if (name == null) {
38-
throw new IllegalArgumentException("name");
39-
}
38+
Objects.requireNonNull(name, "name");
4039

41-
final TraceScope oldScope = list.add(name, new DefaultTraceScope(name));
42-
return oldScope;
40+
return map.put(name, new DefaultTraceScope(name));
4341
}
4442

4543
public void clear() {
46-
list.clear();
44+
map.clear();
4745
}
4846
}

profiler/src/main/java/com/navercorp/pinpoint/profiler/util/NameValueList.java

-87
This file was deleted.

profiler/src/test/java/com/navercorp/pinpoint/profiler/util/NameValueListTest.java

-74
This file was deleted.

0 commit comments

Comments
 (0)