Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support] The collector version is 2.5.2 and the protocol is thrift. However, I find that the gRPC protocol is used. #631

Closed
car1000 opened this issue Jul 2, 2024 · 14 comments
Assignees
Labels
py-agent mostly related with python-agent stale

Comments

@car1000
Copy link

car1000 commented Jul 2, 2024

The collector uses the 2.5.2 version. The original protocol thrift is still used.

The agent version 0.5.0 uses gRPC. Is there any reference example or the version is changed to the thrift protocol. 0.5.0 this version to change the protocol can still be used after thrift?

@car1000 car1000 added the py-agent mostly related with python-agent label Jul 2, 2024
@car1000
Copy link
Author

car1000 commented Jul 2, 2024

Which version of pinpoint-c-agent is thrift?

@car1000
Copy link
Author

car1000 commented Jul 2, 2024

pinpoint-c-agent can you give an example of thrift?

@eeliu
Copy link
Collaborator

eeliu commented Jul 3, 2024

@car1000
Copy link
Author

car1000 commented Jul 3, 2024

@car1000

pinpoint-apm/pinpoint#9932
I understand this 9932, this is to remove the thrift protocol and use gRPC, but we are still using thrift, want to use pinpoint-c-agent this project, currently 0.5.0 can support the thrift protocol, what is the reference, I change the protocol, to make it thrift compatible?

@car1000
Copy link
Author

car1000 commented Jul 3, 2024

I understand this 9932, this is to remove the thrift protocol and use gRPC, but we are still using thrift, want to use pinpoint-c-agent this project, currently 0.5.0 can support the thrift protocol, what is the reference, I change the protocol, to make it thrift compatible?
@eeliu

@eeliu
Copy link
Collaborator

eeliu commented Jul 3, 2024

As for pinpoint-c-agent, we add a protocol adapter (collector-agent). You do not need to care about thrift or gprc, it does.

BYW, pinpoint-c-agent only for python/php, not java.

@car1000
Copy link
Author

car1000 commented Jul 3, 2024

As for pinpoint-c-agent, we add a protocol adapter (collector-agent). You do not need to care about thrift or gprc, it does.

BYW, pinpoint-c-agent only for python/php, not java.

Yes, because we were monitoring java projects, now enhance monitoring python projects so use pinpoint-c-agent, a protocol adapter (collector-agent) how is this compatible with thrift protocol in 0.5.0? Can I get a demo?

@eeliu

@car1000
Copy link
Author

car1000 commented Jul 3, 2024

Yes, because we were monitoring java projects, now enhance monitoring python projects so use pinpoint-c-agent, a protocol adapter (collector-agent) how is this compatible with thrift protocol in 0.5.0? Can I get a demo?

@eeliu

@eeliu
Copy link
Collaborator

eeliu commented Jul 3, 2024

@car1000 which framework you use ?

You can get some demo at https://github.com/pinpoint-apm/pinpoint-c-agent/tree/dev/testapps

@car1000
Copy link
Author

car1000 commented Jul 3, 2024

Sorry, you may have misunderstood. The demo I'm talking about is the 0.5.0 version of pinpoint-c-agent changed to the thrift protocol. I'd like to have an example of this.

@eeliu

@eeliu
Copy link
Collaborator

eeliu commented Jul 5, 2024

Sorry, not support any more

@car1000
Copy link
Author

car1000 commented Jul 5, 2024

Can't the current 0.5.0 be changed to be compatible with thrift protocol?

@eeliu

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Aug 5, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
py-agent mostly related with python-agent stale
Projects
None yet
Development

No branches or pull requests

2 participants