Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number.isNumber is not a function #14

Open
filetvignon opened this issue Nov 28, 2020 · 2 comments
Open

Number.isNumber is not a function #14

filetvignon opened this issue Nov 28, 2020 · 2 comments

Comments

@filetvignon
Copy link

Not sure if this module is maintained anymore, but in trying to use it I realized that start.js uses Number.isNumber(opts.expiry) // (line 37), however that is not a function. Maybe change it to something like typeof opts.expiry !== 'number' || Number.isNaN(opts.expiry)?

@mcollina
Copy link
Member

Not really - would you like to send a PR to fresh this module and fix the the bug?

@filetvignon
Copy link
Author

Ok, I created a pull request #15 , but since this isn't really maintained anymore, I don't think it should be mentioned in Pino's official docs, as this package already has some outdated dependencies as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants