From 6d803a7da22152d2431b497cc548b06468da1b60 Mon Sep 17 00:00:00 2001 From: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Date: Fri, 16 Oct 2026 21:31:40 -0700 Subject: [PATCH] perf(web): the sidebar chrome compiles without manual memoization Co-Authored-By: Claude Opus 5.5 --- .../src/components/sidebar/SidebarChrome.tsx | 35 +++++++++---------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/apps/web/src/components/sidebar/SidebarChrome.tsx b/apps/web/src/components/sidebar/SidebarChrome.tsx index 45db59b4f44a..e7a61f6e9927 100644 --- a/apps/web/src/components/sidebar/SidebarChrome.tsx +++ b/apps/web/src/components/sidebar/SidebarChrome.tsx @@ -1,6 +1,6 @@ import { ArrowLeftIcon, ChartNoAxesColumnIcon, SettingsIcon } from "lucide-react"; import type { ReactNode } from "react"; -import { memo, useCallback } from "react"; +import { memo } from "react"; import { Link, useLocation, useNavigate } from "@tanstack/react-router"; import { useEnvironmentIdentificationMode } from "../../hooks/useSettings"; @@ -81,14 +81,11 @@ export function SidebarBrandWidthProbe({ }: { onWidthChange: (width: number) => void; }) { - const observeWidth = useCallback( - (probe: HTMLDivElement) => { - return observeResize(probe, ([entry]) => { - if (entry) onWidthChange(entry.borderBoxSize[0]?.inlineSize ?? probe.offsetWidth); - }); - }, - [onWidthChange], - ); + const observeWidth = (probe: HTMLDivElement) => { + return observeResize(probe, ([entry]) => { + if (entry) onWidthChange(entry.borderBoxSize[0]?.inlineSize ?? probe.offsetWidth); + }); + }; return (
isSidebarUtilityPage(location.pathname), }); const pullRequestsSupported = usePullRequestsSupported(); - const closeMobileSidebar = useCallback(() => { + const closeMobileSidebar = () => { if (isMobile) { setOpenMobile(false); } - }, [isMobile, setOpenMobile]); - const handlePullRequestsClick = useCallback(() => { + }; + const handlePullRequestsClick = () => { closeMobileSidebar(); void navigate({ to: "/pull-requests", search: readPullRequestListPreferences(), }); - }, [closeMobileSidebar, navigate]); - const handleSettingsClick = useCallback(() => { + }; + const handleSettingsClick = () => { closeMobileSidebar(); void navigate({ to: "/settings" }); - }, [closeMobileSidebar, navigate]); + }; - const handleUsageClick = useCallback(() => { + const handleUsageClick = () => { if (isMobile) { setOpenMobile(false); } void navigate({ to: "/usage" }); - }, [isMobile, navigate, setOpenMobile]); + }; - const handleBackClick = useCallback(() => { + const handleBackClick = () => { closeMobileSidebar(); void navigateToMainApp(); - }, [closeMobileSidebar, navigateToMainApp]); + }; return (