From e628cd373310b8573ed472d061ccd360579a5805 Mon Sep 17 00:00:00 2001 From: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Date: Fri, 16 Oct 2026 21:36:43 -0700 Subject: [PATCH] perf(web): the CLI authorize surface compiles without manual memoization Co-Authored-By: Claude Opus 5.5 --- .../src/components/cloud/ConnectCliAuthSurface.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/web/src/components/cloud/ConnectCliAuthSurface.tsx b/apps/web/src/components/cloud/ConnectCliAuthSurface.tsx index 7248323cc08c..155b4471247f 100644 --- a/apps/web/src/components/cloud/ConnectCliAuthSurface.tsx +++ b/apps/web/src/components/cloud/ConnectCliAuthSurface.tsx @@ -1,6 +1,6 @@ import { useAuth, useClerk } from "@clerk/react"; import { readConnectAuthorizeRequest } from "@t3tools/shared/connectAuth"; -import { useCallback, useEffect, useRef, useState } from "react"; +import { useEffect, useEffectEvent, useRef, useState } from "react"; import { buildConnectCliClerkAuthorizeUrl, @@ -45,7 +45,7 @@ export function ConnectCliAuthorizeSurface() { const signInOpened = useRef(false); const redirecting = useRef(false); - const openSignIn = useCallback(() => { + const openSignIn = () => { if (!request) { return; } @@ -55,7 +55,8 @@ export function ConnectCliAuthorizeSurface() { isElectron, ), ); - }, [clerk, request]); + }; + const openSignInOnLoad = useEffectEvent(openSignIn); useEffect(() => { if (!request || !isLoaded || redirecting.current) { @@ -64,7 +65,7 @@ export function ConnectCliAuthorizeSurface() { if (!isSignedIn) { if (!signInOpened.current) { signInOpened.current = true; - openSignIn(); + openSignInOnLoad(); } return; } @@ -74,7 +75,7 @@ export function ConnectCliAuthorizeSurface() { } redirecting.current = true; window.location.assign(authorizeUrl); - }, [isLoaded, isSignedIn, openSignIn, request]); + }, [isLoaded, isSignedIn, request]); if (!request) { return (