-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce redundant pack reads during building bitmap filter for delta merge case #9876
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
5cefac1
to
3658763
Compare
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Co-authored-by: Lloyd-Pottiger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
112e089
to
e36245d
Compare
Signed-off-by: gengliqi <[email protected]>
e36245d
to
b00df5f
Compare
What problem does this PR solve?
Issue Number: close #9875
Problem Summary:
This optimization can provide a significant performance boost when the data being read is not updated frequently.
What is changed and how it works?
Run CHBenchmark 1500: Overall 26.5% Improvement
The above table shows the delta rows for each table in
chbench_delta
database.All Stable Performance Comparison
The following table presents the performance improvements for All Stable compared to both the original version (with Delta) and the optimized version (with Delta):
The chbenchmark data was inserted into another database. Then the compact table command is executed. As a result, the data might differ. So there are some differences in the query plans. For example, in Q20, the query plan uses hash partition join and includes late materialization for order_line table in the All Stable version, while original version uses broadcast join and no late materialization for order_line table. This causes Q20 to run slower in All Stable compared to the original version due to exchange overhead and low selectivity.
Check List
Tests
Side effects
Documentation
Release note