Skip to content

planner: improve warning messages for unsupported HASH_JOIN hints #58646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2025
Merged

planner: improve warning messages for unsupported HASH_JOIN hints #58646

merged 4 commits into from
Jan 8, 2025

Conversation

@0xPoe
Copy link
Member

@0xPoe 0xPoe commented Jan 2, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58647

Problem Summary:

What changed and how does it work?

  1. Improved warning message for conflicting HASH_JOIN_BUILD and HASH_JOIN_PROBE hints.
  2. Improved warning about unsupported hints for SemiJoin and AntiSemiJoin with hash join versions 1.
  3. Improved warning about unsupported hints for LeftOuterSemiJoin and AntiLeftOuterSemiJoin.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

改进 HASH_JOIN_BUILD 和 HASH_JOIN_PROBE 不生效的警告消息
Improved warning messages for HASH_JOIN_BUILD and HASH_JOIN_PROBE not taking effect

@0xPoe 0xPoe added the skip-issue-check Indicates that a PR no need to check linked issue. label Jan 2, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2025
@0xPoe 0xPoe removed the skip-issue-check Indicates that a PR no need to check linked issue. label Jan 2, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2025
@codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.5703%. Comparing base (e79d22f) to head (9afe29a).
Report is 19 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58646        +/-   ##
================================================
+ Coverage   73.1071%   73.5703%   +0.4632%     
================================================
  Files          1677       1677                
  Lines        463662     464770      +1108     
================================================
+ Hits         338970     341933      +2963     
+ Misses       103866     101997      -1869     
- Partials      20826      20840        +14
Flag Coverage Δ
integration 42.8426% <40.0000%> (?)
unit 72.2767% <80.0000%> (-0.0073%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7240% <ø> (+0.0149%) ⬆️

0xPoe
0xPoe commented Jan 2, 2025
View reviewed changes
Copy link
Member Author

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2025
@0xPoe
Copy link
Member Author

0xPoe commented Jan 5, 2025

/retest

@0xPoe 0xPoe force-pushed the rustin-patch-hash-join-hints branch from f0d4ded to a8c48c7 Compare January 6, 2025 03:26
@0xPoe 0xPoe force-pushed the rustin-patch-hash-join-hints branch from a8c48c7 to 9afe29a Compare January 6, 2025 06:09
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2025
@0xPoe
Copy link
Member Author

0xPoe commented Jan 6, 2025

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 6, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2025
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 8, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-06 08:08:50.308006441 +0000 UTC m=+168273.596838147: ☑️ agreed by time-and-fate.
  • 2025-01-08 07:57:41.965528761 +0000 UTC m=+340405.254360460: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 7bee5a7 into pingcap:master Jan 8, 2025
24 checks passed
breezewish added a commit that referenced this pull request Jan 8, 2025
@breezewish
Merge commit '510d0037b18f258f505abc6cf13a8128563e9359' into wenxuan/…
3f825ba 
…long-vector

* commit '510d0037b18f258f505abc6cf13a8128563e9359':
  *: upgrade pd client to make sure tso client initiate successfully (#58752)
  ttl, test: scale TTL workers during the fault tests (#58750)
  planner: improve warning messages for unsupported HASH_JOIN hints (#58646)
  planner: prealloc the slices in the SplitCorColAccessCondFromFilters (#58785)
  ddl: supports non-unique global index (#58678)
  util/stmtsummary: add the network traffic related fields (#58101)
  var: enable `pd_enable_follower_handle_region` as default (#58385)
  statistics: refactor stats meta handling to use DeltaUpdate for multi-table support (#58657)
  parser: move 'model' to 'ast' pkg (#58704)
  statistics: add recover to protect background task (#58739)
  disttask: cancel subtask context if scheduled away (#58615)
  *: don't handle live updates of column size (#58596)
  *: fix a bug for default_authentication_plugin (2) (#58723)
  dupdetect: gRPC cancel should trigger retry (#58542)
  *: fix a bug for default_authentication_plugin (#57391)
  distsql: Fix backoff execution info inaccurate issue (#58707)
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@0xPoe @zeminzhou
planner: improve warning messages for unsupported HASH_JOIN hints (pi…
a8ce895 
…ngcap#58646)

close pingcap#58647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AilinKid AilinKid AilinKid approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve warning messages for unsupported HASH_JOIN hints

3 participants

@0xPoe @AilinKid @time-and-fate