Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Detach method for RecordSet to detach a record set from the session context #54090

Closed
YangKeao opened this issue Jun 18, 2024 · 0 comments · Fixed by #54091
Closed

Add a Detach method for RecordSet to detach a record set from the session context #54090

YangKeao opened this issue Jun 18, 2024 · 0 comments · Fixed by #54091
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

To achieve the lazy cursor fetch functionality, we'll need to detach the executor -> recordSet -> resultSet from the session context. The PR to add Detach method for executor is WIP #53336. At the same time, we can add a method for recordSet to detach the content of it from the session context.

We need to carefully handle the following things:

  1. *ExecStmt, which will be used to upload the statistical information after executing the statement.
  2. *execStmtResult, which will auto-commit the transaction after executing the statement.

For this issue, we'll create a simple RecordSet, to run read-only statement without statistical information and not allow running in an explicit transaction.

@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Jun 18, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in e036274 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant