Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically adjust GOMEMLIMIT for br clp #53777

Closed
Leavrth opened this issue Jun 4, 2024 · 2 comments · Fixed by #53793
Closed

Automatically adjust GOMEMLIMIT for br clp #53777

Leavrth opened this issue Jun 4, 2024 · 2 comments · Fixed by #53793
Labels
component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented Jun 4, 2024

Enhancement

@Leavrth Leavrth added type/enhancement The issue or PR belongs to an enhancement. component/br This issue is related to BR of TiDB. labels Jun 4, 2024
@Tristan1900
Copy link
Contributor

I am reviewing the br: set memory limit PR and trying to understand the reason of doing this memory enhancement, could you add a few lines of description of why we are doing it? Thanks

@Leavrth
Copy link
Contributor Author

Leavrth commented Jul 17, 2024

I am reviewing the br: set memory limit PR and trying to understand the reason of doing this memory enhancement, could you add a few lines of description of why we are doing it? Thanks

There are too much temporary memory allocation during the backup/restore, such as download backupmeta including many tables' information(TableInfo), and unmarshal/marshal the TableInfo or statistic. So we need to set GOMEMLIMIT for the br binary process, otherwise these temporary memory cannot be GCed in time.

This PR will set the GOMEMLIMIT in default. If users are not satisfied with the default value, they can set it to override by:

GOMEMLIMIT=16GiB ./br restore full ...

@ti-chi-bot ti-chi-bot bot closed this as completed in 2c47cd5 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants