Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session.SetMemoryFootprintChangeHook is called for each call of Txn() #53763

Closed
ekexium opened this issue Jun 3, 2024 · 0 comments · Fixed by #53764
Closed

session.SetMemoryFootprintChangeHook is called for each call of Txn() #53763

ekexium opened this issue Jun 3, 2024 · 0 comments · Fixed by #53764
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@ekexium
Copy link
Contributor

ekexium commented Jun 3, 2024

Enhancement

session.SetMemoryFootprintChangeHook repeats meaninglessly for each call of Txn(), while it does not have to. It costs extra CPU time in the hot path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

txn: do not create hook closure if it is already set ekexium/tidb
1 participant
@ekexium