Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use FlagSkipXXXCheck to in types.Context to determine whether to check the string or not #47479

Closed
Tracked by #47355
lcwangchao opened this issue Oct 9, 2023 · 1 comment · Fixed by #47481
Closed
Tracked by #47355

use FlagSkipXXXCheck to in types.Context to determine whether to check the string or not #47479

lcwangchao opened this issue Oct 9, 2023 · 1 comment · Fixed by #47481
Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Oct 9, 2023 •
edited
Loading

Enhancement

see #47355 for detail

We need to remove SkipUTF8Check, SkipASCIICheck and SkipUTF8MB4Check from stmtctx.StatementContext and move these semantics to types.Context to decouple stmtctx and types package.
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Oct 9, 2023
This was referenced Oct 9, 2023
Closed
Merged
@lcwangchao
Copy link
Collaborator Author

/sig sql-infra

@ti-chi-bot ti-chi-bot bot added the sig/sql-infra SIG: SQL Infra label Oct 9, 2023
@ti-chi-bot ti-chi-bot bot closed this as completed in 85eaf96 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@lcwangchao