Fixed #290 -- Importing from django.core.urlresolvers is deprecated in favor of django.urls #291

felixxm · 2016-10-29T20:52:41Z

RemovedInDjango20Warning: Importing from django.core.urlresolvers is deprecated in favor of django.urls

coveralls · 2016-10-29T21:10:25Z

Coverage remained the same at 100.0% when pulling 448a02a on felixxm:issue-290 into aaa4516 on pinax:master.

paltman

Thanks for this. Just a couple small style corrections and we can get this merged.

paltman · 2016-10-30T15:07:17Z

pinax/stripe/tests/test_middleware.py

@@ -1,8 +1,11 @@
-from django.core.urlresolvers import reverse
+from django.contrib.auth import authenticate, login, logout, get_user_model


We like to keep the *.contrib imports in their own section of imports after the other django imports.

paltman · 2016-10-30T15:07:54Z

pinax/stripe/tests/test_views.py

@@ -1,8 +1,11 @@
-from django.core.urlresolvers import reverse
+from django.contrib.auth import get_user_model


Let's keep this in a contrib section of imports after the django imports, please.

…re.urlresolvers is deprecated in favor of django.urls

coveralls · 2016-10-30T15:20:22Z

Coverage remained the same at 100.0% when pulling d1995af on felixxm:issue-290 into aaa4516 on pinax:master.

felixxm · 2016-11-01T12:14:43Z

@paltman Done.

paltman

Awesome! Thanks!

coveralls · 2016-12-13T14:52:19Z

Coverage remained the same at 100.0% when pulling 8d426c2 on felixxm:issue-290 into d12c367 on pinax:master.

coveralls · 2016-12-13T14:52:19Z

Coverage remained the same at 100.0% when pulling 8d426c2 on felixxm:issue-290 into d12c367 on pinax:master.

coveralls · 2016-12-13T14:52:19Z

Coverage remained the same at 100.0% when pulling 8d426c2 on felixxm:issue-290 into d12c367 on pinax:master.

coveralls · 2016-12-21T21:17:58Z

Changes Unknown when pulling ede4af4 on felixxm:issue-290 into ** on pinax:master**.

coveralls · 2016-12-21T21:17:58Z

Changes Unknown when pulling ede4af4 on felixxm:issue-290 into ** on pinax:master**.

coveralls · 2016-12-21T21:17:58Z

Changes Unknown when pulling ede4af4 on felixxm:issue-290 into ** on pinax:master**.

coveralls · 2016-12-21T21:17:58Z

Changes Unknown when pulling ede4af4 on felixxm:issue-290 into ** on pinax:master**.

coveralls · 2016-12-21T21:53:56Z

Coverage remained the same at 100.0% when pulling ede4af4 on felixxm:issue-290 into 6615388 on pinax:master.

felixxm force-pushed the issue-290 branch from c2484f0 to 448a02a Compare October 29, 2016 21:01

paltman reviewed Oct 30, 2016

View reviewed changes

Fixed pinax#290 -- RemovedInDjango20Warning: Importing from django.co…

d1995af

…re.urlresolvers is deprecated in favor of django.urls

felixxm force-pushed the issue-290 branch from 448a02a to d1995af Compare October 30, 2016 15:12

Merge branch 'master' into issue-290

8d426c2

paltman approved these changes Dec 13, 2016

View reviewed changes

paltman added 2 commits December 21, 2016 15:49

Merge branch 'master' into issue-290

a004c5a

Merge branch 'master' into issue-290

ede4af4

Merge branch 'master' into issue-290

5eec34f

paltman merged commit 08859b2 into pinax:master Dec 21, 2016

felixxm deleted the issue-290 branch December 22, 2016 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed #290 -- Importing from django.core.urlresolvers is deprecated in favor of django.urls #291

Fixed #290 -- Importing from django.core.urlresolvers is deprecated in favor of django.urls #291

felixxm commented Oct 29, 2016

coveralls commented Oct 29, 2016 •

edited

Loading

paltman left a comment

paltman Oct 30, 2016

paltman Oct 30, 2016

felixxm Oct 30, 2016

coveralls commented Oct 30, 2016 •

edited

Loading

felixxm commented Nov 1, 2016

paltman left a comment

coveralls commented Dec 13, 2016 •

edited

Loading

coveralls commented Dec 13, 2016

coveralls commented Dec 13, 2016 •

edited

Loading

coveralls commented Dec 21, 2016 •

edited

Loading

coveralls commented Dec 21, 2016

coveralls commented Dec 21, 2016 •

edited

Loading

coveralls commented Dec 21, 2016 •

edited

Loading

coveralls commented Dec 21, 2016 •

edited

Loading

		@@ -1,8 +1,11 @@
		from django.core.urlresolvers import reverse
		from django.contrib.auth import authenticate, login, logout, get_user_model

		@@ -1,8 +1,11 @@
		from django.core.urlresolvers import reverse
		from django.contrib.auth import get_user_model

Fixed #290 -- Importing from django.core.urlresolvers is deprecated in favor of django.urls #291

Fixed #290 -- Importing from django.core.urlresolvers is deprecated in favor of django.urls #291

Conversation

felixxm commented Oct 29, 2016

coveralls commented Oct 29, 2016 • edited Loading

paltman left a comment

Choose a reason for hiding this comment

paltman Oct 30, 2016

Choose a reason for hiding this comment

paltman Oct 30, 2016

Choose a reason for hiding this comment

felixxm Oct 30, 2016

Choose a reason for hiding this comment

coveralls commented Oct 30, 2016 • edited Loading

felixxm commented Nov 1, 2016

paltman left a comment

Choose a reason for hiding this comment

coveralls commented Dec 13, 2016 • edited Loading

coveralls commented Dec 13, 2016

coveralls commented Dec 13, 2016 • edited Loading

coveralls commented Dec 21, 2016 • edited Loading

coveralls commented Dec 21, 2016

coveralls commented Dec 21, 2016 • edited Loading

coveralls commented Dec 21, 2016 • edited Loading

coveralls commented Dec 21, 2016 • edited Loading

coveralls commented Oct 29, 2016 •

edited

Loading

coveralls commented Oct 30, 2016 •

edited

Loading

coveralls commented Dec 13, 2016 •

edited

Loading

coveralls commented Dec 13, 2016 •

edited

Loading

coveralls commented Dec 21, 2016 •

edited

Loading

coveralls commented Dec 21, 2016 •

edited

Loading

coveralls commented Dec 21, 2016 •

edited

Loading

coveralls commented Dec 21, 2016 •

edited

Loading