Raise validation errors to prevent duplicates

Author: paltman

pinax/documents/forms.py

@@ -21,6 +21,12 @@ class Meta:
             "parent": forms.HiddenInput,
         }
 
+    def clean(self):
+        name = self.cleaned_data["name"]
+        parent = self.cleaned_data.get("parent")
+        if Folder.already_exists(name, parent):
+            raise forms.ValidationError("{} already exists.".format(name))
+
     def __init__(self, *args, **kwargs):
         folders = kwargs.pop("folders")
         super(FolderCreateForm, self).__init__(*args, **kwargs)
@@ -48,6 +54,12 @@ def clean_file(self):
             raise forms.ValidationError("File will exceed storage capacity.")
         return value
 
+    def clean(self):
+        name = self.cleaned_data["file"].name
+        folder = self.cleaned_data.get("folder")
+        if Document.already_exists(name, folder):
+            raise forms.ValidationError("{} already exists.".format(name))
+
 
 class UserMultipleChoiceField(forms.ModelMultipleChoiceField):
 

pinax/documents/tests/test_views.py

@@ -93,6 +93,19 @@ def test_post_create_with_illegal_parent(self):
             self.assertFalse("object" in self.last_response.context)
             self.assertFalse(Folder.objects.filter(name=folder_name))
 
+    def test_post_create_with_duplicate_name(self):
+        """
+        Ensure POST does not create a folder with duplicate name
+        """
+        folder_name = "Spindle"
+        Folder.objects.create(name=folder_name, author=self.user, modified_by=self.user)
+        post_args = {"name": folder_name}
+        with self.login(self.user):
+            response = self.post(self.create_urlname, data=post_args, follow=True)
+            self.response_200(response)
+            self.assertTrue("{} already exists.".format(folder_name) in str(response.context["form"].errors))
+            self.assertFalse("object" in self.last_response.context)
+
     def test_detail(self):
         """
         Ensure we can see folder detail.
@@ -301,6 +314,20 @@ def test_post_create_with_illegal_parent(self):
             self.assertFalse("object" in self.last_response.context)
             self.assertFalse(Document.objects.filter(name=simple_file.name))
 
+    def test_post_create_with_duplicate_name(self):
+        """
+        Ensure POST does not create a document with duplicate name
+        """
+        simple_file = SimpleUploadedFile("delicious.txt", self.file_contents)
+        Document.objects.create(name="delicious.txt", author=self.user, file=simple_file, modified_by=self.user)
+        simple_file = SimpleUploadedFile("delicious.txt", self.file_contents)
+        post_args = {"name": "file", "file": simple_file}
+        with self.login(self.user):
+            response = self.post(self.create_urlname, data=post_args, follow=True)
+            self.response_200(response)
+            self.assertTrue("delicious.txt already exists." in str(response.context["form"].errors))
+            self.assertFalse("object" in self.last_response.context)
+
     def test_detail(self):
         """
         Ensure we can see document detail.