Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some type fixes #13789

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Some type fixes #13789

merged 2 commits into from
Dec 14, 2022

Conversation

fashxp
Copy link
Member

@fashxp fashxp commented Dec 13, 2022

Part of #13656

@fashxp fashxp added the Task label Dec 13, 2022
@fashxp fashxp added this to the 11.0.0 milestone Dec 13, 2022
@github-actions
Copy link

Review Checklist

  • Target branch (10.6 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@mcop1
Copy link
Contributor

mcop1 commented Dec 14, 2022

Looks good, but we should check the corresponding PhpDocs in 10.6 and adapt them if necessary.

@mcop1 mcop1 mentioned this pull request Dec 14, 2022
Merged
@mcop1 mcop1 merged commit fba610b into 11.x Dec 14, 2022
@mcop1 mcop1 deleted the more-type-fixes branch December 14, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankse blankse blankse left review comments

Assignees

@mcop1 mcop1

Labels
Task
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fashxp @mcop1 @blankse