Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecommerce] [Backoffice] Don't use hardcoded PaymentProviders #86

Open
ultramegatom opened this issue Feb 17, 2020 · 2 comments
Open

[Ecommerce] [Backoffice] Don't use hardcoded PaymentProviders #86

ultramegatom opened this issue Feb 17, 2020 · 2 comments

Comments

@ultramegatom
Copy link
Contributor

The Payment section of the Backoffice should be refactored to not use hardcoded values. Makes it impossible to use it along with custom providers unless you override the view script...

We should also get rid of the magic method call: getProvider_%s_amount and provide some usefull interface:

https://github.com/pimcore/pimcore/blob/master/bundles/EcommerceFrameworkBundle/Resources/views/admin_order/detail.html.twig#L181

@andreas-gruenwald
Copy link
Contributor

@ultramegatom Can you add a solution suggestion?

@ultramegatom
Copy link
Contributor Author

@andreas-gruenwald
make an interface/abstract class and let the objectbrick itself decide what to return here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants