Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Remove dependency to Config class #43

Open
mcop1 opened this issue Apr 24, 2023 · 1 comment
Open

[Task] Remove dependency to Config class #43

mcop1 opened this issue Apr 24, 2023 · 1 comment

Comments

@mcop1
Copy link
Contributor

mcop1 commented Apr 24, 2023

Config class shouldn´t be used for admin configuration (configuration which are a children to the pimcore_admin node).

  • Add the needed configurations as parameter on the container
  • Inject the specific parameters to the services

For example:
Add a configuration for sessions_bags here

$container->setParameter('pimcore_admin.user', $config['user']);

$container->setParameter('pimcore_admin.session.attribute_bags', $config['session']['attribute_bags']);

Then inject the parameter here

Pimcore\Bundle\AdminBundle\EventListener\AdminSessionBagListener: ~

    Pimcore\Bundle\AdminBundle\EventListener\AdminSessionBagListener:
        arguments:
            $config: ['%pimcore_admin.session.attribute_bags%']
@mcop1 mcop1 added the Task label Apr 24, 2023
@fashxp fashxp added this to the 1.0.0 milestone May 4, 2023
@lukmzig lukmzig removed this from the 1.0.0 milestone May 11, 2023
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants