Spinner not hiding in Object Tree after Drag / Drop

[solverat]

In some cases, the tree spinner won't hide anymore.

Setup

You need to have an exact setup like this (reproducible on demo.pimcore.fun):

Now:

• Refresh "Home"
• Open Subfolder "Test"
• Open Subfolder "Test2"
• Open Folder "New"
• DO NOT open Folder "Archive
• Drag "news-4" into "Archive"

⇾ Spinner will show up forever.

Trace

After the element has been dropped, EXTJS again fires the beforeitemmove event (Don't know why):

admin-ui-classic-bundle/public/js/pimcore/object/tree.js

Line 195 in a8b9492

"beforeitemmove": this.onTreeNodeBeforeMove.bind(this),

Which starts the tree loader:

admin-ui-classic-bundle/public/js/pimcore/object/tree.js

Line 393 in a8b9492

tree.loadMask.show();

Since there is no drop event, the spinner stays forever.

Possible Fix

Move tree.loadMask.show(); into the onTreeNodesDrop method, right after this line:

admin-ui-classic-bundle/public/js/pimcore/object/tree.js

Lines 281 to 282 in a8b9492

	let tree = this.treeNodeMoveParameter.oldParent.getOwnerTree();

Screencast

Bildschirmaufzeichnung.vom.30.11.2023.17_38_10.mp4

[github-actions]

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.