Misc brokerd backend repairs #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to send a message in the `NoBsWs.fixture()` exit when the ws is not currently disconnected causes a double `._stack.close()` call which will corrupt `trio`'s coro stack. Instead only do the unsub if we detect the ws is still up. Also drops the legacy `backfill_bars()` module endpoint. Fixes #437
See more details in the GH comment: #373 (comment) More or less we need to pull and include the transfer fees for withdrawals in our ledger tracking but this serves as a sloppy workaround for the moment.
Seems that by default their history indexing rounds down/back to the previous time step, so make sure we add a minute inside `Client.bars()` when the `end_dt=None`, indicating "get the latest bar". Add a breakpoint block that should trigger whenever the latest bar vs. the latest epoch time is mismatched; we'll remove this after some testing verifying the history bars issue is resolved. Further this drops the legacy `backfill_bars()` endpoint which has been deprecated and unused for a while.
goodboy
added
testing
broker-backend
goodboy
requested review from
guilledk and
esmegl
and removed request for
guilledk
guilledk
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides some topically chosen
brokerdrelated fixes to multiple brokers this also adjusts our CI script to always run on any PRs.Fixes by backend:
ib:.get_head_time()calls since it's not a necessary call during a throttle conditionkraken:src_fiatparsing/processing in position calcs during broker-mode startupsubscribe()fixture to only do unsub msging when connected on reconnect/disconnect.connected()predicate method added toNoBsWspps.tomltracking by acceptingkraken's claim of a zero size since we still don't have full xfer fee support built into that subsystem for those clear event entrieskraken: balance <-> position disparities with crypto/crypto pairs #373backfill_bars()history endpointbinance:subscribe()fixture to only do unsub msging when connected on reconnect/disconnectderibit:backfill_bars()history endpoint