-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave update partially broke this #56
Comments
Hey! For me it still works. So it's probably an A/B test from youtube, which makes this a bit hard to test. Can you make a screenshot of the HTML of the thumbnail that has not changed? Like so: with inspect element Then i should be able to figure out why it is not changing for you. Probably the src url in the img tag is different on your youtube version. Thanks! |
Sorry did not explain it clearly, can you also expand the yt-image HTML tag? So I can see the actual image URL? like on my screenshot |
Yeah, it appears to be an issue with Brave. Thanks for the heads up. I just posted a bug report on brave's github. Time will tell if they care enough to fix it. |
I found a dirty fix for impatient people like me:
somewhere in the code and run. Dirty and bad fix, but at least makes Youtube usable. |
Can you elaborate? Where do you get this extension? |
|
Very much appreciated! |
Hi everyone, thanks for the temporary fix @Izofeu. But a proper fix should be possible, likely just something has to be changed in how the thumbnail url listeners are setup. Specifically here:
Unfortunately the extension still works fine for me, this is probably due to an A/B test from youtube or Brave, which is why it is broken for some people. Strangely enough the URL to the thumbnail still seems to be the same, which is why I asked for the screenshots. So i'm a bit stumped on what it could possibly be, for me its just a guessing game. Hoping someone who has this A/B test can figure it out and submit a pull request. Edit: Only just realised for some reason you guys are only talking about the Brave browser. I'll see soon if I can also replicate the issue and fix it. Bit busy at the moment. |
If you need any assistance in troubleshooting this issue, I'm more than happy to help. Sorry for my spaghetti fix but I'm not much of a coder 😃 |
The problem is fixed after deleting these two folders.
edit: it doesn't work again... |
I looked into this and I'm pretty sure it's connected to this issue: I can confirm that if you disable&enable the extension it works until the browser restart |
Thanks for this finding! Almost certain that that is the issue then. Hope brave fixes it soon, Kind of odd that brave deviates from standard chromium behaviour. Don't really feel like I am doing very advanced/weird things with my extension. |
FYI DeArrow works on brave, I've been testing it out and I think I'm gonna just replace CBR with DeArrow. |
Second DeArrow. I am a big fan of CBR but I think DeArrow is a bit better, total clickbait death is non-negotiable for me. |
Appears to be fixed in the latest brave update according to #66? Issue on brave's side is now also closed, with people verifying that this extension now works properly again: brave/brave-browser#30854 |
it still technically works, but it requires that you toggle it off and on each time you visit youtube.
The text was updated successfully, but these errors were encountered: