Skip to content

Capitalize Words not removing CAPS #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
girstenbrei opened this issue Dec 4, 2020 · 3 comments
Open

Capitalize Words not removing CAPS #33

girstenbrei opened this issue Dec 4, 2020 · 3 comments
Labels
bug Something isn't working firefox only issues that only apply to the firefox version

Comments

@girstenbrei
Copy link

Hey there, first: awesome work! Short, concise add-on doing exactly one thing and one thing right.

The only thing I found was the following: the Capitalize Words options doesn't de-caps words for me. Technically it does what it says, giving words a capital first letter. But (at least in my mind 😄) I assumed, this would be followed by all lowercase. I appended you an example of the two settings and their respective results.
A small but related thing: I noticed that one letter 'words' are also capitalized. True to the setting, but IMHO these are always fill and it might be visually easier to flow through a title, if these short letters, if already lowercase, stay lowercase. Gives the eye some vertical markers as a reference.

But, for both points I'm happy to be convinced otherwise!

I'm running v0.4.1 of the add-on on a 83.0 (64-bit) Firefox.

Thanks for the add-on again! Can I help you with anything else (apart from implementing it, sorry, don't now how to do it and out of time atm ...)

Greets,
Chris

Cap Words
Dont change

@pietervanheijningen
Copy link
Owner

Thanks for pointing it out!

Yes indeed it's supposed to first make everything lowercase, and then capitalise each word. This is what it does in chrome, but apparently the same code works differently in firefox.
I'll see if I can fix it sometime, but I can't guarantee that its fixable, i'm currently only changing the titles using CSS, which works great, but is very limited in what I can do.
Adding capitalise words to the extension was already a very hacky solution, that only barely works as it is.

@pietervanheijningen pietervanheijningen added bug Something isn't working firefox only issues that only apply to the firefox version labels Dec 5, 2020
@mimmiechan
Copy link

Does not seem to be possible with pure CSS. Unless, perhaps you use some illegal string replacement hack.

@sKopheK
Copy link

sKopheK commented Mar 1, 2024

this is very much needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefox only issues that only apply to the firefox version
Projects
None yet
Development

No branches or pull requests

4 participants