Fix config options for Android release builds #295
Conversation
wwwdata
force-pushed
the
fix-android-config-options
branch
from
8928a71 to
80731dd
Compare
|
13 days to review this very important change? |
|
looks like @pichillilorenzo is inactive since December. I hope he wakes up again and maintains this awesome Plugin. But in the meantime, I guess you will have to make your own fork and merge in the patches that you need. This is also how we currently do it for the project I am working for. |
Using reflection was not a good idea because when the Android App is compiled for release mode, some code optimizations are executed. The fields of the configuration classes were then renamed and the mapping via reflections did not work again. Now everything has an explicit mapping form the untyped HashMap to the class fields and vice versa.
wwwdata
force-pushed
the
fix-android-config-options
branch
from
80731dd to
a7100ae
Compare
|
it works, thank you |
|
Yep, thanks a lot! |
|
oh, nice, i've opened an issue on this 2 weeks ago: #315 Apparently, another workaround to fix this is to find the missing classes with logcat and add them to proguard. Maybe we should retake this package and publish a new one on pub.dev. Anyone want to collaborate on this? it's a shame this package is not maintained anymore |
|
@arnaudelub hm, really looks like the original maintainer abandoned this repo here. If you want to make a fork, I would be in to collaborate on it. On my current project, we are heavily using web views and I already have some other minor changes that are internal for now. It would be nice to have a more responsive open source repo where I then could open PRs for everything that I find is missing/needs fixing. |
|
@wwwdata nice, so let's do it, but i think i'll fork it and rebuild a new plugin so we can put it on pub.dev |
|
Released new version |
Connection with issue(s)
Resolve issue #294
Testing and Review Notes
Using reflection was not a good idea because when the Android App is compiled for release mode, some code optimizations are executed. The fields of the configuration classes were then renamed and the mapping via reflections did not work anymore. Now everything has an explicit mapping from the untyped HashMap to the class fields and vice versa.
In order to test this, just compile a release build of the example repository and try to set some other default options. It will not work. A good example is to set
useShouldOverrideUrlLoadingto true and then use the callback for it.