Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing 'ties'? connections between notes in midi import #343

Open
Svetlana-T opened this issue Aug 4, 2024 · 1 comment
Open

missing 'ties'? connections between notes in midi import #343

Svetlana-T opened this issue Aug 4, 2024 · 1 comment

Comments

@Svetlana-T
Copy link

the connection is missing in pianobooster

image

imported from .mid - note you need to rename it from test1.mid.zip to test1.mid - it is not actually a zip file - i just named it this way for github to accept the file as an attachment

test1.mid.zip

pianobooster 1.0.0 on windows 11

the issue was always here, it did not work previously

@Martchus
Copy link
Contributor

Martchus commented Aug 4, 2024

The element you highlighted with the red circle in the score looks like a slur (and not a tie). However, it doesn't really matter because PianoBooster has no support for any of those.

I once tried to add support for ties and showing note durations in general. I noticed that some work has actually already been done and I continued a little bit before realizing that this is really too much effort for a project like this. I suppose my next best approach would be to rewrite PianoBooster based on MuseScore for proper rendering in general but I haven't had the time to make any significant progress on that.

I suppose slurs are even more complicated then ties because I am not even sure how a slur would be represented in MIDI out of my head. So in addition to the challenge of rendering it properly, knowing if/when to render one from the MIDI information might already be challenging. (A tie is simpler because it is basically just one normal note with a very long duration.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants