Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release docker image with Pi-hole v4.1 #369

Closed
ghost opened this issue Dec 10, 2018 · 10 comments
Closed

Please release docker image with Pi-hole v4.1 #369

ghost opened this issue Dec 10, 2018 · 10 comments

Comments

@ghost
Copy link

ghost commented Dec 10, 2018

There is new version of Pihole: https://github.com/pi-hole/pi-hole/releases/tag/v4.1
The latest tag is for v4.0

@ase1590
Copy link

ase1590 commented Dec 11, 2018

Seconding this.

@diginc
Copy link
Collaborator

diginc commented Dec 11, 2018

I have #370 ready to go for review/testing. I pushed the dev image tag with 4.1 which needs a little more testing before going to the prod tag. There was one known issue with arm images (#361) I should really make sure is taken care of before releasing to production.

@ase1590
Copy link

ase1590 commented Dec 12, 2018

Just pulled in pihole/pihole:dev from dockerhub on my x86_64 plex server.
Docker Digest: sha256:5ff26713b6a9e81754c46a6e6de7e57376449b1d546a2588cd2ffd231a9db844

The web interface still reports that it's 4.0 and that the image was built 5 weeks ago but docker claims 2 days ago it was updated...

wonder if there's a propagation delay for dockerhub?

@diginc
Copy link
Collaborator

diginc commented Dec 13, 2018

Ah I think the deploy script has '4.0' hard coded in it and needs updated too, my bad.

@diginc
Copy link
Collaborator

diginc commented Dec 14, 2018

OK I believe the real v4.1 is pushed to the dev tag now.

Edit: ok I lied again. I pulled it and ran it locally and it seems to have not updated correctly. I think this is more of a docker hub problem than it is me actually not pushing it this time. They have trouble letting you overwrite manifests. Edit: Found this bug I might have to do unique / versioned dev tags instead of just one that is always the same name.

OK, I implemented a workaround to updating manifests. Looks like there's no way to properly delete manifests through CLI yet and the old versions were persisting on my PC.

@ase1590
Copy link

ase1590 commented Dec 14, 2018 via email

@YAMLcase
Copy link

Can we also get the 'latest' tag to point to 4.1?

@ase1590
Copy link

ase1590 commented Dec 14, 2018

@YAMLcase please note that the latesttag is for working production releases. As this image is not yet widely tested, its likely not suitable just yet to move it from dev to latest.

@BigSnicker
Copy link

BigSnicker commented Dec 22, 2018

This build is problematic for me, unlike earlier versions... the install goes cleanly and works well, but it always breaks after a container restart.

Any chance there's word on the 4.1.2 hotfixes to see if they help?

@diginc
Copy link
Collaborator

diginc commented Jan 11, 2019

This release is done. Anyone looking for resolution to issues take a look at the top of the readme : https://github.com/pi-hole/docker-pi-hole/blob/dev/README.md#docker-pi-hole-v411-important-upgrade-notes

I'll duplicate this data in the github release's notes when I merge dev to master tonight and cut a release with these improved checks for misconfiguration

@diginc diginc closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants