add ability to configure queue by ARN #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not entirely sure how you would like me to resolve this codeclimate feedback. IMHO the concept/logic for processing the config input has probably out-grown the Queue class an needs to be split out. That would allow for more thorough testing of that code as well because it can be done in isolation. |
|
Hi @nippysaurus Thank you. Shoryuken 5.0.5 is out including your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pass at adding the ability to set queue location as an ARN value.
I removed use of the AWS parser as it violates the
'aws-sdk-core', '>= 2'dependency (it was only added recently) and I don't think it was intended for outside use anyway.Related: #602