Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint option to SQS CLI #595

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

jmsanders
Copy link

I use Localstack for local development. I can successfully point shoryuken start at my localstack endpoint by configuring SQS in a Rails initializer and passing the --rails/-R option. However, I can't do anything similar to point shoryuken sqs at my localstack endpoint.

This change introduces an endpoint class option for the SQS CLI. Now, the CLI's SQS client is initialized with the provided endpoint if one is provided. The option can be set by passing --endpoint, -e, or setting the SHORYUKEN_SQS_ENDPOINT environment variable.

I considered instead passing the existing --rails/-R option and running through the same environment loading that takes places in the Shoryuken CLI, but that felt like overkill here - especially because running through all of the Rails initialization could add a lot of startup time to these SQS commands. Please let me know if you disagree with that decision or if there's anything else I can do to help get this merged! Thanks!

@jmsanders jmsanders requested a review from phstc February 18, 2020 18:05
@phstc phstc merged commit a98ec09 into ruby-shoryuken:master Feb 20, 2020
@phstc
Copy link
Collaborator

phstc commented Feb 20, 2020

@jmsanders awesome 🎉 I released a new version including your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants