Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use Localstack for local development. I can successfully point
shoryuken start
at my localstack endpoint by configuring SQS in a Rails initializer and passing the--rails/-R
option. However, I can't do anything similar to pointshoryuken sqs
at my localstack endpoint.This change introduces an endpoint class option for the SQS CLI. Now, the CLI's SQS client is initialized with the provided endpoint if one is provided. The option can be set by passing
--endpoint
,-e
, or setting theSHORYUKEN_SQS_ENDPOINT
environment variable.I considered instead passing the existing
--rails/-R
option and running through the same environment loading that takes places in the Shoryuken CLI, but that felt like overkill here - especially because running through all of the Rails initialization could add a lot of startup time to these SQS commands. Please let me know if you disagree with that decision or if there's anything else I can do to help get this merged! Thanks!