Allcentury async delivery adapter #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change delivering 5000 messages took on average:
user system total real
6.351633 0.535708 6.887341 ( 42.842282)
After this change, I am able to delivery 5000 messages in:
user system total real
7.160261 1.237327 8.397588 ( 7.676820)
In my rough benchmarks I see a 5-7x increase. This is valuable for us because we enqueue a large number of jobs at once in a loop, something akin to:
```ruby
MyModel.expensive_query.each { |obj| MyJob.perform_later(obj) }
```
Usable by setting:
```ruby
config.active_job.queue_adapter = ActiveJob::QueueAdapters::ShoryukenConcurrentSendAdapter.new
```
Handlers are available for both success and failure and must respond to
call.
Example:
```ruby
adapter = ActiveJob::QueueAdapters::ShoryukenConcurrentSendAdapter.new
adapter.success_handler = ->(job, options) {
StatsD.increment(job.class.name + "success") }
adapter.error_handler = ->(err, (job, options)) {
StatsD.increment(job.class.name + "failure") }
config.active_job.queue_adapter = adapter
```
…y/shoryuken into allcentury-async-delivery-adapter
phstc
force-pushed
the
allcentury-async-delivery-adapter
branch
from
703ce0f
to
565874a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes on top of #588