Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queue name to inline executor #532

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Add queue name to inline executor #532

merged 1 commit into from
Nov 17, 2018

Conversation

atongen
Copy link
Contributor

@atongen atongen commented Nov 17, 2018 •
edited
Loading

Making sqs_msg OpenStruct from InlineExecutor look more like Shoryuken::Message allows easier testing when alternate queue name is passed in as an option.

@phstc phstc merged commit 90097b0 into ruby-shoryuken:master Nov 17, 2018
@phstc
Copy link
Collaborator

phstc commented Nov 17, 2018

@atongen looks good. Thank you! Added to master 🍻

@phstc phstc changed the title Add queue name to inline executor sqs_msg Add queue name to inline executor Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atongen @phstc