Preserves parent worker class options #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiokr
force-pushed
the
feature/class-options
branch
2 times, most recently
from
9dab652
to
d216cf4
Compare
Uses a `shoryuken_class_attribute` implementation that preserves parent worker class options and allow child classes to override those. Example: ``` class ParentWorker include ShoryukenWorker shoryuken_options queue: "myqueue", auto_delete: true end class ChildWorker < ParentWorker shoryuken_options auto_delete: false end ``` In this example, the ChildWorker will carry on the parent options, and override the `auto_delete` configuration.
fabiokr
force-pushed
the
feature/class-options
branch
from
d216cf4
to
8c04fb3
Compare
|
cc/ @phstc |
|
@phstc CodeClimate is complaining about the |
newx
approved these changes
Dec 29, 2017
|
@phstc Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #450
Uses a
shoryuken_class_attributeimplementation that preserves parentworker class options and allow child classes to override those.
Example:
In this example, the ChildWorker will carry on the parent options, and
override the
auto_deleteconfiguration.