Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -t option to CLI #449

Merged
merged 1 commit into from
Dec 28, 2017
Merged

Add -t option to CLI #449

merged 1 commit into from
Dec 28, 2017

Conversation

maschwenk
Copy link
Contributor

From the wiki:

https://github.com/phstc/shoryuken/wiki/Signals#term

Tells Shoryuken to hard shutdown within a timeout. Any processors that do not finish within the timeout are hard terminated and their messages are pushed back to AWS SQS. The timeout defaults to 8 seconds since all Heroku processes must exit within 10 seconds.

The described -t option was never actually configured in Thor

The timeout can be defined through the -t option or in the -C shoryuken.yml config by setting the timeout: N value.

Tells Shoryuken to hard shutdown within a timeout. Any processors that do not finish within the timeout are hard terminated and their messages are pushed back to AWS SQS. The timeout defaults to 8 seconds since all Heroku processes must exit within 10 seconds.
@phstc phstc merged commit 6a11ebe into ruby-shoryuken:master Dec 28, 2017
@phstc
Copy link
Collaborator

phstc commented Dec 28, 2017

Thanks @maschwenk. Added to master 🍻

@phstc
Copy link
Collaborator

phstc commented Jan 3, 2018

@maschwenk 3.2.0 is out with your change! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants