Look for polling strategy inside groups config

[atyndall]

Allows group config to specify polling strategy in the .yml like so;

timeout: 1140
delay: 60

groups:
  r:
    concurrency: 1
    polling_strategy: StrictPriority
    queues:
      - x
      - y
      - z
  q:
    concurrency: 1
    polling_strategy: StrictPriority
    queues:
      - a
      - b
      - c

or like so

timeout: 1140
delay: 60
concurrency: 1
polling_strategy: StrictPriority
queues:
  - x
  - y
  - z

Note: this change would be backwards incompatible with the current way of setting strategy described here. I have a version that also preserves that behaviour, but it's more complicated.

[phstc]

@atyndall constantize depends on ActiveSupport.

Maybe the simplest way of doing it would be:

if strategy == 'StrictPriority'
  Polling::StrictPriority
else
  Polling::WeightedRoundRobin
end

WDYT?

[phstc]

@atyndall WDYT about adding some test cases?

# options_spec.rb

describe '.polling_strategy' do
  context 'when not set' do
    specify do
      expect(Shoryuken.polling_strategy('default')).to eq Shoryuken::Polling::WeightedRoundRobin
    end
  end

  context 'when set' do
    before do
      Shoryuken.options[:groups] = {
        'group1' => {
          polling_strategy: 'StrictPriority'
        }
      }
    end

    specify do
      expect(Shoryuken.polling_strategy('default')).to eq Shoryuken::Polling::WeightedRoundRobin
      expect(Shoryuken.polling_strategy('group1')).to eq Shoryuken::Polling::StrictPriority
    end
  end
end

[atyndall]

@phstc Made changes as you suggested. I also restructured it a bit to ensure that if a user mistypes a string, it errors instead of silently picking the WeightedRoundRobin strategy.

[phstc]

@atyndall yay added to master 🍻 I will ship a new release tomorrow including your changes.

[phstc]

@atyndall 3.1.7 is out with your change 🍻