Fail fast on bad URL #413
Fail fast on bad URL #413
Conversation
|
Man! |
maschwenk
force-pushed
the
bug/fail-fast-on-bad-url
branch
from
6029cef
to
bd3d591
Compare
lib/shoryuken/queue.rb
Outdated
| name_or_url.start_with?('https://sqs.') ? set_url(name_or_url) : set_name(name_or_url) | ||
| queue_url_params = parse_queue_url_params(name_or_url) | ||
| self.name = queue_url_params[:queue_name] | ||
| self.url = client.get_queue_url(queue_url_params) |
There was a problem hiding this comment.
@maschwenk WDYT about something like this for saving a request, since we need to check fifo? anyway, and we don't have to assume URL convention for queues: *_, account_id, queue_name = URI.parse(name_or_url).path.split('/')?
Do you mind also adding a test case queue_spec?
There was a problem hiding this comment.
Ah! forgot you need to check fifo? at some point anyway. Will take a look
|
Basically just copy-pasted what you had there, changed the names to |
|
@maschwenk looks good. I added a test and merged into master! 🍻 |
Closes #412
get_queue_urlallows you to optionally specify the account_id of the queue, so this basically programmatically verifies that the queue is correct and verifies that the correct permissions are in place to use the URL in the first place.http://docs.aws.amazon.com/sdkforruby/api/Aws/SQS/Client.html#get_queue_url