Fix miss handling empty batch fetches #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phstc
force-pushed
the
hotfix/fix-batch-delete-375
branch
3 times, most recently
from
26a003c
to
1d7f8c2
Compare
phstc
commented
Jun 2, 2017
| @@ -98,7 +98,8 @@ def assign(queue, sqs_msg) | |||
| end | |||
|
|
|||
| def dispatch_batch(queue) | |||
| batch = @fetcher.fetch(queue, BATCH_LIMIT) | |||
| return if (batch = @fetcher.fetch(queue, BATCH_LIMIT)).none? | |||
There was a problem hiding this comment.
@dotpyfe ☝️ was the issue, it was trying to assign/process/delete all that stuff for empty batches.
phstc
force-pushed
the
hotfix/fix-batch-delete-375
branch
from
1d7f8c2
to
49c081f
Compare
phstc
force-pushed
the
hotfix/fix-batch-delete-375
branch
from
49c081f
to
3aa91e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #375